Fix Francesco Faraone feedback

Author: martinconstante

connect/resources/template.py

@@ -25,7 +25,7 @@ def list(self, product_id):
         if not product_id:
             raise ValueError('Invalid product Id for list template')
         response, _ = self._api.get(
-            '/public/v1/products/'+product_id+'/templates/',
+            '/public/v1/products/' + product_id + '/templates/',
             params={'scope': 'asset', 'type': 'fulfillment'},
         )
         response = json.loads(response)

examples/apiary_scenarios/asset_accept_workflow.py

@@ -47,19 +47,19 @@ def dispatch(self, request):
     def process_request(self, request):
         template_resource = TemplateResource()
         for item in request.asset.items:
-            purchasRequestId = request.id
-            productId = request.asset.product.id
-            npm = item.mpn
-        url = VENDOR_API_URL + "tenant?externalId=" + npm
+            purchase_request_id = request.id
+            product_id = request.asset.product.id
+            mpn = item.mpn
+        url = VENDOR_API_URL + 'tenant?externalId=' + mpn
 
         response = requests.get(url, data='').json()
         if response['status'] == 'ready':
-            templates = template_resource.list(productId)
+            templates = template_resource.list(product_id)
             for template in templates:
-                templateId = template['id']
+                template_id = template['id']
                 break
-            body = {"activation_tile": templateId}
-            self.approve(purchasRequestId, body)
+            body = {"activation_tile": template_id}
+            self.approve(purchase_request_id, body)
         return response
 
 

examples/apiary_scenarios/asset_request_workflow.py

@@ -45,36 +45,36 @@ def dispatch(self, request):
 
     def process_request(self, request):
         for item in request.asset.items:
-            npm = item.mpn
+            mpn = item.mpn
             quantity = item.quantity
             break
 
-        url = VENDOR_API_URL + "tenant?externalId=" + npm
+        url = VENDOR_API_URL + "tenant?externalId=" + mpn
         response = requests.get(url, data='').json()
-        firstName = request.asset.tiers.customer.contact_info.contact.first_name
-        lastName = request.asset.tiers.customer.contact_info.contact.last_name
+        first_name = request.asset.tiers.customer.contact_info.contact.first_name
+        last_name = request.asset.tiers.customer.contact_info.contact.last_name
         address = request.asset.tiers.customer.contact_info.address_line1
-        postalCode = request.asset.tiers.customer.contact_info.postal_code
-        accountPhone = request.asset.tiers.customer.contact_info.contact.phone_number.phone_number
+        postal_code = request.asset.tiers.customer.contact_info.postal_code
+        account_phone = request.asset.tiers.customer.contact_info.contact.phone_number.phone_number
         if response['externalId'] != request.asset.id:
-            url = VENDOR_API_URL + "tenant"
+            url = VENDOR_API_URL + 'tenant'
             payload = {
                     'Attributes': {
                         'product': {
-                            'item': npm,
+                            'item': mpn,
                             'quantity': quantity
                         },
                         'account': {
-                            'accountFirstName': firstName,
-                            'accountLastName': lastName,
+                            'accountFirstName': first_name,
+                            'accountLastName': last_nName,
                             'accountCompany': request.asset.tiers.customer.name,
                             'accountAddress': address,
                             'accountCity': request.asset.tiers.customer.contact_info.city,
                             'accountState': request.asset.tiers.customer.contact_info.state,
-                            'accountPostalCode': postalCode,
+                            'accountPostalCode': postal_code,
                             'accountCountry': request.asset.tiers.customer.contact_info.country,
                             'accountEmail': request.asset.tiers.customer.contact_info.contact.email,
-                            'accountPhone': accountPhone
+                            'accountPhone': account_phone
                         }
                     }
                 }