Reverted external_id field to string

Author: JaviCerveraIngram

connect/models/asset.py

@@ -24,7 +24,7 @@ def get_item_by_id(self, identity):
 
 class AssetSchema(BaseSchema):
     status = fields.Str()
-    external_id = fields.Int()
+    external_id = fields.Str()
     external_uid = fields.UUID()
     product = fields.Nested(ProductSchema, only=('id', 'name'))
     connection = fields.Nested(

connect/models/hub.py

@@ -24,4 +24,4 @@ def make_object(self, data):
 
 class HubsSchemaMixin(Schema):
     hub = fields.Nested(HubSchema, only=('id', 'name'))
-    external_id = fields.Int()
+    external_id = fields.Str()

connect/models/tiers.py

@@ -18,7 +18,7 @@ class Tier(BaseModel):
 class TierSchema(BaseSchema):
     name = fields.Str()
     contact_info = fields.Nested(ContactInfoSchema)
-    external_id = fields.Int()
+    external_id = fields.Str()
     external_uid = fields.UUID()
 
     @post_load

tests/response2.json

@@ -13,7 +13,7 @@
           "name": "Marc FSG"
         }
       },
-      "external_id": 899,
+      "external_id": "899",
       "id": "AS-893-495-635-9",
       "items": [
         {
@@ -105,7 +105,7 @@
             "postal_code": "30690",
             "state": "Nevada"
           },
-          "external_id": 889,
+          "external_id": "889",
           "id": "TA-0-5870-9239-0029",
           "name": "Kaiser LLC"
         },
@@ -129,7 +129,7 @@
             "postal_code": "12111",
             "state": "Alaska"
           },
-          "external_id": 1,
+          "external_id": "1",
           "id": "TA-0-7251-3930-7482",
           "name": "ACME Reseller"
         },

tests/test_models.py

@@ -75,7 +75,12 @@ def test_create_model_from_response():
     assert request_obj.marketplace.id == content['marketplace']['id']
     assert request_obj.asset.id == content['asset']['id']
     assert request_obj.asset.product.id == content['asset']['product']['id']
-    assert isinstance(request_obj.asset.external_id, int)
+    try:
+        # Python 2
+        assert isinstance(request_obj.asset.external_id, basestring)
+    except NameError:
+        # Python 3
+        assert isinstance(request_obj.asset.external_id, str)
 
 
 @patch('requests.get', MagicMock(return_value=_get_response2_ok()))