Added globally accessible Config.instance.

Author: JaviCerveraIngram

README.md

@@ -66,12 +66,12 @@ class ExampleRequestProcessor(FulfillmentAutomation):
             return ActivationTileResponse(tile='\n  # Welcome to Fallball!\n\nYes, '
                                                'you decided to have an account in our amazing service!')
             # or
-            # return TemplateResource().render(pk='TEMPLATE_ID', request_id=request.id)
+            # return TemplateResource(self.config).render(pk='TEMPLATE_ID', request_id=request.id)
 
             # aprrove by Template
             return ActivationTemplateResponse(template_id="TL-497-535-242")
             # or
-            # return TemplateResource().get(pk='TEMPLATE_ID')
+            # return TemplateResource(self.config).get(pk='TEMPLATE_ID')
 
         elif request.type == 'change':
             # fail

connect/config.py

@@ -10,6 +10,8 @@
 
 
 class Config(object):
+    instance = None  # Global instance
+
     def __init__(
             self,
             api_url=None,
@@ -62,6 +64,9 @@ def __init__(
             if isinstance(products, str) \
             else products or []
 
+        # Store last created instance
+        Config.instance = self
+
     @property
     def api_url(self):
         return self._api_url

connect/resource/base.py

@@ -16,10 +16,13 @@
 
 class ApiClient(object):
 
-    def __init__(self, config):
-        if not isinstance(config, Config):
+    def __init__(self, config=None):
+        # Assign passed config or globally configured instance
+        self.config = config or Config.instance
+
+        # Assert data
+        if not isinstance(self.config, Config):
             raise ValueError('A valid Config object is required to create an ApiClient')
-        self.config = config
 
     @property
     def headers(self):
@@ -68,15 +71,19 @@ class BaseResource(object):
     api = None
     schema = BaseSchema()
 
-    def __init__(self, config, *args, **kwargs):
+    def __init__(self, config=None, *args, **kwargs):
+        # Assign passed config or globally configured instance
+        self.config = config or Config.instance
+
+        # Assert data
         if not self.__class__.resource:
             raise AttributeError('Resource name not specified in class {}'.format(
                 self.__class__.__name__) + '. Add an attribute `resource` name of the resource')
-        if not isinstance(config, Config):
-            raise ValueError('A valid Config object is required to create a ' + type(self).__name__)
+        if not isinstance(self.config, Config):
+            raise ValueError('A valid Config object must be passed or globally configured '
+                             'to create a ' + type(self).__name__)
         if not BaseResource.api:
             BaseResource.api = ApiClient(config)
-        self.config = config
 
     def build_filter(self):
         res_filter = {}

example/example.py

@@ -34,12 +34,12 @@ def process_request(self, request):
             return ActivationTileResponse(tile='\n  # Welcome to Fallball!\n\nYes, you decided '
                                                'to have an account in our amazing service!')
             # or
-            # return TemplateResource().render(pk='TEMPLATE_ID', request_id=request.id)
+            # return TemplateResource(self.config).render(pk='TEMPLATE_ID', request_id=request.id)
 
             # aprrove by Template
             return ActivationTemplateResponse(template_id="TL-497-535-242")
             # or
-            # return TemplateResource().get(pk='TEMPLATE_ID')
+            # return TemplateResource(self.config).get(pk='TEMPLATE_ID')
 
         elif request.type == 'change':
             # fail

tests/test_config.py

@@ -58,14 +58,35 @@ def test_config_immutable_properties():
     config = Config(file='config.json')
     with pytest.raises(AttributeError):
         config.api_key = conf_dict.get('apiKey')
-    with pytest.raises(AttributeError):
         config.api_url = conf_dict.get('apiEndpoint')
-    with pytest.raises(AttributeError):
         config.products = [conf_dict.get('products')]
 
+
+def test_global_config():
+    Config.instance = None  # Reset global config
+    Config(file='config.json')
+    _assert_global_config()
+
+
+def test_global_config_immutable_properties():
+    Config(file='config.json')
+    with pytest.raises(AttributeError):
+        Config.instance.api_key = conf_dict.get('apiKey')
+        Config.instance.api_url = conf_dict.get('apiEndpoint')
+        Config.instance.products = [conf_dict.get('products')]
+
+
 def _assert_config(config):
     assert config.api_key == conf_dict.get('apiKey')
     assert config.api_url == conf_dict.get('apiEndpoint')
     assert isinstance(config.products, list)
     assert len(config.products) == 1
     assert config.products[0] == conf_dict.get('products')
+
+
+def _assert_global_config():
+    assert Config.instance.api_key == conf_dict.get('apiKey')
+    assert Config.instance.api_url == conf_dict.get('apiEndpoint')
+    assert isinstance(Config.instance.products, list)
+    assert len(Config.instance.products) == 1
+    assert Config.instance.products[0] == conf_dict.get('products')