Commit d4cee5e
authored
Clean up unused logging infrastructure (#234)
* Remove unused AsyncLocalStorage infrastructure
The AsyncLocalStorage infrastructure (loggerStorage, getLogger,
runWithLogger) was set up but never actually used. The codebase uses
explicit logger passing via constructor injection throughout.
This change removes the unused code, simplifies the logging module,
and documents the explicit passing pattern as the canonical approach.
The pattern works well for all scenarios including request context,
background operations, lifecycle events, and long-lived objects.
No breaking changes as the removed functions were never called.
* Add changeset for logging cleanup
* Fix e2e test worker template configuration
Use 'vars' instead of 'env' for environment variables in wrangler template.1 parent 3aba9e8 commit d4cee5e
File tree
10 files changed
+121
-288
lines changed- .changeset
- packages
- sandbox-container/src
- sandbox/src
- openai
- tests/e2e/test-worker
10 files changed
+121
-288
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
331 | 331 | | |
332 | 332 | | |
333 | 333 | | |
334 | | - | |
335 | | - | |
336 | | - | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
337 | 350 | | |
338 | 351 | | |
339 | 352 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | 1 | | |
19 | 2 | | |
20 | 3 | | |
| |||
82 | 65 | | |
83 | 66 | | |
84 | 67 | | |
85 | | - | |
86 | | - | |
87 | 68 | | |
88 | 69 | | |
89 | 70 | | |
| |||
0 commit comments