Skip to content

Commit 4939670

Browse files
committed
fix helm template issue difference
Signed-off-by: Jeffrey Sica <[email protected]>
1 parent e686deb commit 4939670

File tree

6 files changed

+12
-24
lines changed

6 files changed

+12
-24
lines changed

ci/cluster/equinix/runners/16cpu-64gb/values.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,8 @@ template:
227227
volumes:
228228
- name: work
229229
emptyDir: {}
230-
- name: dind-sock
231-
emptyDir: {}
232-
- name: dind-externals
233-
emptyDir: {}
230+
# We need to assume the DIND socket volumes are being provided
231+
# This is because Helm + Argo is busted :) The previous values won't work properly
234232

235233
## Optional controller service account that needs to have required Role and RoleBinding
236234
## to operate this gha-runner-scale-set installation.

ci/cluster/equinix/runners/2cpu-8gb/values.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,8 @@ template:
227227
volumes:
228228
- name: work
229229
emptyDir: {}
230-
- name: dind-sock
231-
emptyDir: {}
232-
- name: dind-externals
233-
emptyDir: {}
230+
# We need to assume the DIND socket volumes are being provided
231+
# This is because Helm + Argo is busted :) The previous values won't work properly
234232

235233
## Optional controller service account that needs to have required Role and RoleBinding
236234
## to operate this gha-runner-scale-set installation.

ci/cluster/equinix/runners/32cpu-256gb/values.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,8 @@ template:
227227
volumes:
228228
- name: work
229229
emptyDir: {}
230-
- name: dind-sock
231-
emptyDir: {}
232-
- name: dind-externals
233-
emptyDir: {}
230+
# We need to assume the DIND socket volumes are being provided
231+
# This is because Helm + Argo is busted :) The previous values won't work properly
234232

235233
## Optional controller service account that needs to have required Role and RoleBinding
236234
## to operate this gha-runner-scale-set installation.

ci/cluster/equinix/runners/4cpu-16gb/values.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,8 @@ template:
227227
volumes:
228228
- name: work
229229
emptyDir: {}
230-
- name: dind-sock
231-
emptyDir: {}
232-
- name: dind-externals
233-
emptyDir: {}
230+
# We need to assume the DIND socket volumes are being provided
231+
# This is because Helm + Argo is busted :) The previous values won't work properly
234232

235233
## Optional controller service account that needs to have required Role and RoleBinding
236234
## to operate this gha-runner-scale-set installation.

ci/cluster/equinix/runners/8cpu-32gb/values.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,8 @@ template:
227227
volumes:
228228
- name: work
229229
emptyDir: {}
230-
- name: dind-sock
231-
emptyDir: {}
232-
- name: dind-externals
233-
emptyDir: {}
230+
# We need to assume the DIND socket volumes are being provided
231+
# This is because Helm + Argo is busted :) The previous values won't work properly
234232

235233
## Optional controller service account that needs to have required Role and RoleBinding
236234
## to operate this gha-runner-scale-set installation.

ci/cluster/equinix/runners/keda-runner/values.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,8 @@ template:
226226
volumes:
227227
- name: work
228228
emptyDir: {}
229-
- name: dind-sock
230-
emptyDir: {}
231-
- name: dind-externals
232-
emptyDir: {}
229+
# We need to assume the DIND socket volumes are being provided
230+
# This is because Helm + Argo is busted :) The previous values won't work properly
233231

234232
## Optional controller service account that needs to have required Role and RoleBinding
235233
## to operate this gha-runner-scale-set installation.

0 commit comments

Comments
 (0)