Skip to content

Commit f154333

Browse files
committed
Elio changes
1 parent 41f3383 commit f154333

File tree

2 files changed

+47
-33
lines changed

2 files changed

+47
-33
lines changed

.github/workflows/publish.yml

Lines changed: 35 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ env:
1111
VERSION: ${{ github.event.release.tag_name }}
1212

1313
jobs:
14-
publish:
15-
runs-on: ubuntu-latest
14+
publish-firefox:
15+
runs-on: ubuntu-24.04
1616
steps:
1717
- uses: actions/checkout@v4
1818

@@ -30,30 +30,7 @@ jobs:
3030
path: codecov-browser-extension-${{ github.event.release.tag_name }}.tar.gz
3131

3232
- name: Install dependencies
33-
run: npm install
34-
35-
- name: Build Chrome extension
36-
run: npm run build
37-
env:
38-
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
39-
40-
- name: Upload built Chrome extension
41-
uses: actions/upload-artifact@v4
42-
with:
43-
name: codecov-chrome-${{ github.event.release.tag_name }}
44-
path: ./dist/
45-
46-
- name: Publish to Chrome
47-
working-directory: dist
48-
run: npx chrome-webstore-upload-cli@3
49-
env:
50-
EXTENSION_ID: "gedikamndpbemklijjkncpnolildpbgo"
51-
CLIENT_ID: ${{ secrets.GOOGLE_WEB_STORE_CLIENT_ID }}
52-
CLIENT_SECRET: ${{ secrets.GOOGLE_WEB_STORE_CLIENT_SECRET }}
53-
REFRESH_TOKEN: ${{ secrets.GOOGLE_WEB_STORE_REFRESH_TOKEN }}
54-
55-
- name: Clean dist
56-
run: rm -r dist
33+
run: npm ci
5734

5835
- name: Build Firefox extension
5936
run: npm run build:firefox
@@ -75,3 +52,35 @@ jobs:
7552
WEB_EXT_CHANNEL: listed
7653
WEB_EXT_UPLOAD_SOURCE_CODE: ../codecov-browser-extension-${{ github.event.release.tag_name }}.tar.gz
7754
WEB_EXT_APPROVAL_TIMEOUT: 0 # Disable timeout for approval
55+
56+
publish-chrome:
57+
runs-on: ubuntu-24.04
58+
steps:
59+
- uses: actions/checkout@v4
60+
61+
- uses: actions/setup-node@v4
62+
with:
63+
node-version: "22"
64+
65+
- name: Install dependencies
66+
run: npm ci
67+
68+
- name: Build Chrome extension
69+
run: npm run build
70+
env:
71+
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
72+
73+
- name: Upload built Chrome extension
74+
uses: actions/upload-artifact@v4
75+
with:
76+
name: codecov-chrome-${{ github.event.release.tag_name }}
77+
path: ./dist/
78+
79+
- name: Publish to Chrome
80+
working-directory: dist
81+
run: npx chrome-webstore-upload-cli@3
82+
env:
83+
EXTENSION_ID: "gedikamndpbemklijjkncpnolildpbgo"
84+
CLIENT_ID: ${{ secrets.GOOGLE_WEB_STORE_CLIENT_ID }}
85+
CLIENT_SECRET: ${{ secrets.GOOGLE_WEB_STORE_CLIENT_SECRET }}
86+
REFRESH_TOKEN: ${{ secrets.GOOGLE_WEB_STORE_REFRESH_TOKEN }}

README.md

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,12 @@ These steps will build the extension in the `dist/` folder.
8888

8989
Node 22, `npm` 10, `git`, and `jq` are required to build the extension.
9090

91+
If you're a reviewer from Mozilla, hi! Please note that we have previously seen differences in build output between AMD64 and ARM64. In our CD pipeline we build on Ubuntu 24.04 AMD64, so please stick to that architecture if possible to eliminate any environment differences.
92+
9193
### Set Local Version
9294

95+
If you're a reviewer from Mozilla, you don't need to do this.
96+
9397
To override the local version of the extension, you can set the `VERSION` environment variable before building. This is useful for testing or development purposes.
9498

9599
E.g.
@@ -99,20 +103,21 @@ $ export VERSION=1.0.0
99103

100104
### Use Development Sentry DSN
101105

106+
If you're a reviewer from Mozilla, you don't need to do this.
107+
102108
If you want to use Sentry while developing, you can override the DSN value by first copying the example config (`cp .env.example .env.local`) and then filling in the environment variable.
103109

104-
### Chrome
110+
### Firefox
105111

106112
```sh
107-
$ npm install
108-
$ npm run build
113+
$ npm ci
114+
$ npm run build:firefox
109115
```
110-
111-
### Firefox
116+
### Chrome
112117

113118
```sh
114-
$ npm install
115-
$ npm run build:firefox
119+
$ npm ci
120+
$ npm run build
116121
```
117122

118123
## About Codecov

0 commit comments

Comments
 (0)