fix: Make error message nullable (#3894)

Author: ajay-sentry

src/pages/OwnerPage/Tabs/TrialReminder/TrialReminder.test.tsx

@@ -123,14 +123,6 @@ describe('TrialReminder', () => {
   }
 
   describe('user has not started a trial', () => {
-    beforeEach(() => {
-      vi.useFakeTimers().setSystemTime(new Date('2023-01-01'))
-    })
-
-    afterEach(() => {
-      vi.useRealTimers()
-    })
-
     describe('user is on a free plan', () => {
       describe('user is part of org', () => {
         it('displays trial upgrade link', async () => {
@@ -165,10 +157,8 @@ describe('TrialReminder', () => {
 
           const { container } = render(<TrialReminder />, { wrapper })
 
-          await waitFor(() =>
-            expect(queryClient.isFetching()).toBeGreaterThan(0)
-          )
-          await waitFor(() => expect(queryClient.isFetching()).toBe(0))
+          await waitFor(() => queryClient.isFetching)
+          await waitFor(() => !queryClient.isFetching)
 
           expect(container).toBeEmptyDOMElement()
         })
@@ -186,8 +176,8 @@ describe('TrialReminder', () => {
 
         const { container } = render(<TrialReminder />, { wrapper })
 
-        await waitFor(() => expect(queryClient.isFetching()).toBeGreaterThan(0))
-        await waitFor(() => expect(queryClient.isFetching()).toBe(0))
+        await waitFor(() => queryClient.isFetching)
+        await waitFor(() => !queryClient.isFetching)
 
         expect(container).toBeEmptyDOMElement()
       })
@@ -235,10 +225,8 @@ describe('TrialReminder', () => {
 
           const { container } = render(<TrialReminder />, { wrapper })
 
-          await waitFor(() =>
-            expect(queryClient.isFetching()).toBeGreaterThan(0)
-          )
-          await waitFor(() => expect(queryClient.isFetching()).toBe(0))
+          await waitFor(() => queryClient.isFetching)
+          await waitFor(() => !queryClient.isFetching)
 
           expect(container).toBeEmptyDOMElement()
         })
@@ -264,8 +252,8 @@ describe('TrialReminder', () => {
 
         const { container } = render(<TrialReminder />, { wrapper })
 
-        await waitFor(() => expect(queryClient.isFetching()).toBeGreaterThan(0))
-        await waitFor(() => expect(queryClient.isFetching()).toBe(0))
+        await waitFor(() => queryClient.isFetching)
+        await waitFor(() => !queryClient.isFetching)
 
         expect(container).toBeEmptyDOMElement()
       })
@@ -314,10 +302,8 @@ describe('TrialReminder', () => {
 
           const { container } = render(<TrialReminder />, { wrapper })
 
-          await waitFor(() =>
-            expect(queryClient.isFetching()).toBeGreaterThan(0)
-          )
-          await waitFor(() => expect(queryClient.isFetching()).toBe(0))
+          await waitFor(() => queryClient.isFetching)
+          await waitFor(() => !queryClient.isFetching)
 
           expect(container).toBeEmptyDOMElement()
         })
@@ -335,23 +321,15 @@ describe('TrialReminder', () => {
 
         const { container } = render(<TrialReminder />, { wrapper })
 
-        await waitFor(() => expect(queryClient.isFetching()).toBeGreaterThan(0))
-        await waitFor(() => expect(queryClient.isFetching()).toBe(0))
+        await waitFor(() => queryClient.isFetching)
+        await waitFor(() => !queryClient.isFetching)
 
         expect(container).toBeEmptyDOMElement()
       })
     })
   })
 
   describe('user cannot trial', () => {
-    beforeEach(() => {
-      vi.useFakeTimers().setSystemTime(new Date('2023-01-01'))
-    })
-
-    afterEach(() => {
-      vi.useRealTimers()
-    })
-
     it('does not display upgrade link', async () => {
       setup({
         planValue: Plans.USERS_PR_INAPPY,
@@ -362,8 +340,8 @@ describe('TrialReminder', () => {
 
       const { container } = render(<TrialReminder />, { wrapper })
 
-      await waitFor(() => expect(queryClient.isFetching()).toBeGreaterThan(0))
-      await waitFor(() => expect(queryClient.isFetching()).toBe(0))
+      await waitFor(() => queryClient.isFetching)
+      await waitFor(() => !queryClient.isFetching)
 
       expect(container).toBeEmptyDOMElement()
     })
@@ -381,22 +359,14 @@ describe('TrialReminder', () => {
 
       const { container } = render(<TrialReminder />, { wrapper })
 
-      await waitFor(() => expect(queryClient.isFetching()).toBeGreaterThan(0))
-      await waitFor(() => expect(queryClient.isFetching()).toBe(0))
+      await waitFor(() => queryClient.isFetching)
+      await waitFor(() => !queryClient.isFetching)
 
       expect(container).toBeEmptyDOMElement()
     })
   })
 
   describe('API returns no information', () => {
-    beforeEach(() => {
-      vi.useFakeTimers().setSystemTime(new Date('2023-01-01'))
-    })
-
-    afterEach(() => {
-      vi.useRealTimers()
-    })
-
     it('returns nothing', async () => {
       setup({
         planValue: Plans.USERS_DEVELOPER,
@@ -406,22 +376,14 @@ describe('TrialReminder', () => {
 
       const { container } = render(<TrialReminder />, { wrapper })
 
-      await waitFor(() => expect(queryClient.isFetching()).toBeGreaterThan(0))
-      await waitFor(() => expect(queryClient.isFetching()).toBe(0))
+      await waitFor(() => queryClient.isFetching)
+      await waitFor(() => !queryClient.isFetching)
 
       expect(container).toBeEmptyDOMElement()
     })
   })
 
   describe('app is running in self hosted', () => {
-    beforeEach(() => {
-      vi.useFakeTimers().setSystemTime(new Date('2023-01-01'))
-    })
-
-    afterEach(() => {
-      vi.useRealTimers()
-    })
-
     it('renders nothing', async () => {
       setup({
         planValue: Plans.USERS_DEVELOPER,

src/pages/RepoPage/FailedTestsTab/FailedTestsPage/FailedTestsErrorBanner/FailedTestsErrorBanner.tsx

@@ -54,7 +54,7 @@ const ProcessingTimeoutBanner = () => (
 const UnsupportedFormatBanner = ({
   errorMessage,
 }: {
-  errorMessage: string
+  errorMessage: string | null
 }) => (
   <Banner variant="warning">
     <BannerHeading>

src/pages/RepoPage/FailedTestsTab/FailedTestsPage/hooks/useTestResultsTestSuites/useTestResultsTestSuites.tsx

@@ -20,7 +20,7 @@ const TestResultsTestSuitesSchema = z.object({
                   latestUploadError: z
                     .object({
                       errorCode: z.nativeEnum(ErrorCodeEnum),
-                      errorMessage: z.string(),
+                      errorMessage: z.string().nullable(),
                     })
                     .nullable(),
                 })