From 86e149ce04af1353c9105f763f6f94698ef598c6 Mon Sep 17 00:00:00 2001 From: Spencer Murray Date: Tue, 15 Jul 2025 15:02:36 -0400 Subject: [PATCH 1/7] Improve coverage % on flags table --- .../subroute/FlagsTable/FlagsTable.tsx | 26 ++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx b/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx index 121a3de22f..fe22386a6e 100644 --- a/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx +++ b/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx @@ -18,6 +18,7 @@ import A from 'ui/A' import CoverageProgress from 'ui/CoverageProgress' import Icon from 'ui/Icon' import Spinner from 'ui/Spinner' +import { Tooltip } from 'ui/Tooltip' import DeleteFlagModal from './DeleteFlagModal' import useRepoFlagsTable from './hooks' @@ -38,7 +39,30 @@ const columns = [ cell: ({ renderValue }) => renderValue(), }), columnHelper.accessor('coverage', { - header: () => 'Coverage %', + header: () => ( +
+ Average coverage % + + + +
+ +
+
+ + + The average coverage percentage over the selected time period. + This is not the coverage percentage as of this moment. + + + +
+
+
+ ), cell: ({ renderValue }) => renderValue(), enableSorting: false, }), From 073809d59bf5e00864c4edd108a51ee12b67e2f9 Mon Sep 17 00:00:00 2001 From: Spencer Murray Date: Tue, 15 Jul 2025 15:04:03 -0400 Subject: [PATCH 2/7] Fix test --- .../FlagsTab/subroute/FlagsTable/FlagsTable.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.test.tsx b/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.test.tsx index 08386b3dd5..2285296422 100644 --- a/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.test.tsx +++ b/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.test.tsx @@ -252,7 +252,7 @@ describe('FlagsTable', () => { const flags = await screen.findByText('Flags') expect(flags).toBeInTheDocument() - const coverage = await screen.findByText('Coverage %') + const coverage = await screen.findByText('Average coverage %') expect(coverage).toBeInTheDocument() const trend = await screen.findByText('Trend') From e6b61dc2546f6c137142c484e7198d934181ca0e Mon Sep 17 00:00:00 2001 From: Spencer Murray Date: Tue, 15 Jul 2025 15:26:21 -0400 Subject: [PATCH 3/7] Verbose tho --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b8c83643d8..e95eda953d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -242,7 +242,7 @@ jobs: - name: Upload coverage to Production if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'codecov' }} run: | - codecovcli -u ${{ secrets.CODECOV_URL }} do-upload -t ${{ secrets.CODECOV_ORG_TOKEN }} --fail-on-error --name "VITEST-${{ matrix.runner-index }}" + codecovcli -u ${{ secrets.CODECOV_URL }} do-upload -t ${{ secrets.CODECOV_ORG_TOKEN }} --fail-on-error --name "VITEST-${{ matrix.runner-index }}" --verbose - name: Upload coverage to Staging if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'codecov' }} From 2c920b1f903e4f7986e0b3e32344443de0ef0d3c Mon Sep 17 00:00:00 2001 From: Spencer Murray Date: Tue, 15 Jul 2025 15:30:01 -0400 Subject: [PATCH 4/7] Fr tho --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e95eda953d..69dba05e19 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -242,7 +242,7 @@ jobs: - name: Upload coverage to Production if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'codecov' }} run: | - codecovcli -u ${{ secrets.CODECOV_URL }} do-upload -t ${{ secrets.CODECOV_ORG_TOKEN }} --fail-on-error --name "VITEST-${{ matrix.runner-index }}" --verbose + codecovcli --verbose -u ${{ secrets.CODECOV_URL }} do-upload -t ${{ secrets.CODECOV_ORG_TOKEN }} --fail-on-error --name "VITEST-${{ matrix.runner-index }}" - name: Upload coverage to Staging if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'codecov' }} From a0b7824fe418ee65c5d58225e571462641793bf0 Mon Sep 17 00:00:00 2001 From: Spencer Murray Date: Tue, 15 Jul 2025 16:33:24 -0400 Subject: [PATCH 5/7] Tweak copy --- .../CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx b/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx index fe22386a6e..62f05da27d 100644 --- a/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx +++ b/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx @@ -54,8 +54,9 @@ const columns = [ side="right" className="w-64 rounded-md bg-ds-gray-primary p-3 text-xs text-ds-gray-octonary" > - The average coverage percentage over the selected time period. - This is not the coverage percentage as of this moment. + This is the average flag coverage over the selected time period. + To view current coverage % for a given flag, navigate to the + Overview tab and filter by flag. From f297c9bd7e2758a777327d2005af414cea8bc1e1 Mon Sep 17 00:00:00 2001 From: Spencer Murray Date: Tue, 15 Jul 2025 16:33:55 -0400 Subject: [PATCH 6/7] Revert verbose --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 69dba05e19..b8c83643d8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -242,7 +242,7 @@ jobs: - name: Upload coverage to Production if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'codecov' }} run: | - codecovcli --verbose -u ${{ secrets.CODECOV_URL }} do-upload -t ${{ secrets.CODECOV_ORG_TOKEN }} --fail-on-error --name "VITEST-${{ matrix.runner-index }}" + codecovcli -u ${{ secrets.CODECOV_URL }} do-upload -t ${{ secrets.CODECOV_ORG_TOKEN }} --fail-on-error --name "VITEST-${{ matrix.runner-index }}" - name: Upload coverage to Staging if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'codecov' }} From efa0405ebb44c5ecd8152daef5e70e4a4bdbcaa1 Mon Sep 17 00:00:00 2001 From: Spencer Murray Date: Wed, 16 Jul 2025 14:22:58 -0400 Subject: [PATCH 7/7] Add link to overview tab --- .../FlagsTab/subroute/FlagsTable/FlagsTable.tsx | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx b/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx index 62f05da27d..4934b47080 100644 --- a/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx +++ b/src/pages/RepoPage/CoverageTab/FlagsTab/subroute/FlagsTable/FlagsTable.tsx @@ -56,7 +56,14 @@ const columns = [ > This is the average flag coverage over the selected time period. To view current coverage % for a given flag, navigate to the - Overview tab and filter by flag. + + Overview tab + {' '} + and filter by flag.