Skip to content

Commit 22e2189

Browse files
authored
bug fix in embedding deletion (#889)
1 parent a161462 commit 22e2189

File tree

2 files changed

+7
-6
lines changed
  • backend/python/app

2 files changed

+7
-6
lines changed

backend/python/app/modules/indexing/run.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,6 @@ async def delete_embeddings(self, record_id: str, virtual_record_id: str) -> Non
666666

667667
ids = [point.id for point in result[0]] #type: ignore
668668
self.logger.info(f"🎯 Filter: {filter_dict}")
669-
self.logger.info(f"🎯 Ids: {ids}")
670669

671670
try:
672671
await self.get_embedding_model_instance()

backend/python/app/services/messaging/kafka/handlers/record.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,7 @@ async def process_event(self, event_type: str, payload: dict) -> bool:
132132
record = await self.event_processor.arango_service.get_document(
133133
record_id, CollectionNames.RECORDS.value
134134
)
135-
if record is None:
136-
self.logger.error(f"❌ Record {record_id} not found in database")
137-
return False
138135

139-
if virtual_record_id is None:
140-
virtual_record_id = record.get("virtualRecordId")
141136

142137
self.logger.info(
143138
f"Processing record {record_id} with event type: {event_type}. "
@@ -155,6 +150,13 @@ async def process_event(self, event_type: str, payload: dict) -> bool:
155150
# self.logger.info(f"Scheduled update for record {record_id}")
156151
await self.event_processor.processor.indexing_pipeline.delete_embeddings(record_id, virtual_record_id)
157152

153+
if record is None:
154+
self.logger.error(f"❌ Record {record_id} not found in database")
155+
return False
156+
157+
if virtual_record_id is None:
158+
virtual_record_id = record.get("virtualRecordId")
159+
158160

159161
if extension is None and mime_type != "text/gmail_content":
160162
extension = payload.get("extension", None)

0 commit comments

Comments
 (0)