Skip to content
This repository was archived by the owner on Nov 4, 2024. It is now read-only.

Commit 2ed6484

Browse files
committed
fix(CNV-48780): rename credentials of the container registry
Rename credentials to match containerized data importer naming convnetion: - accessKeyId: "${id}" - secretKey: "${token}" Signed-off-by: Ben Oukhanov <[email protected]>
1 parent 43e5698 commit 2ed6484

File tree

6 files changed

+22
-25
lines changed

6 files changed

+22
-25
lines changed

examples/kubevirt-disk-uploader-tekton.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,8 @@ metadata:
144144
name: kubevirt-disk-uploader-credentials-tekton
145145
type: Opaque
146146
data:
147-
registryUsername: "<REGISTRY_USERNAME>"
148-
registryPassword: "<REGISTRY_PASSWORD>"
147+
accessKeyId: "<ACCESS_KEY_ID>"
148+
secretKey: "<SECRET_KEY>"
149149
---
150150
apiVersion: tekton.dev/v1
151151
kind: Task
@@ -169,16 +169,16 @@ spec:
169169
- name: kubevirt-disk-uploader-step
170170
image: quay.io/boukhano/kubevirt-disk-uploader:latest
171171
env:
172-
- name: REGISTRY_USERNAME
172+
- name: ACCESS_KEY_ID
173173
valueFrom:
174174
secretKeyRef:
175175
name: kubevirt-disk-uploader-credentials-tekton
176-
key: registryUsername
177-
- name: REGISTRY_PASSWORD
176+
key: accessKeyId
177+
- name: SECRET_KEY
178178
valueFrom:
179179
secretKeyRef:
180180
name: kubevirt-disk-uploader-credentials-tekton
181-
key: registryPassword
181+
key: secretKey
182182
- name: VM_NAMESPACE
183183
valueFrom:
184184
fieldRef:

kubevirt-disk-uploader.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,16 @@ spec:
3939
image: quay.io/boukhano/kubevirt-disk-uploader:latest
4040
imagePullPolicy: Always
4141
env:
42-
- name: REGISTRY_USERNAME
42+
- name: ACCESS_KEY_ID
4343
valueFrom:
4444
secretKeyRef:
4545
name: kubevirt-disk-uploader-credentials
46-
key: registryUsername
47-
- name: REGISTRY_PASSWORD
46+
key: accessKeyId
47+
- name: SECRET_KEY
4848
valueFrom:
4949
secretKeyRef:
5050
name: kubevirt-disk-uploader-credentials
51-
key: registryPassword
51+
key: secretKey
5252
- name: VM_NAMESPACE
5353
valueFrom:
5454
fieldRef:
@@ -74,5 +74,5 @@ metadata:
7474
name: kubevirt-disk-uploader-credentials
7575
type: Opaque
7676
data:
77-
registryUsername: "<REGISTRY_USERNAME>"
78-
registryPassword: "<REGISTRY_PASSWORD>"
77+
accessKeyId: "<ACCESS_KEY_ID>"
78+
secretKey: "<SECRET_KEY>"

main.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,10 @@ func pushContainerDisk(image v1.Image, imageDestination string, pushTimeout int)
149149
ctx, cancel := context.WithTimeout(context.Background(), time.Minute*time.Duration(pushTimeout))
150150
defer cancel()
151151

152-
userName := os.Getenv("REGISTRY_USERNAME")
153-
password := os.Getenv("REGISTRY_PASSWORD")
154152
auth := &authn.Basic{
155-
Username: userName,
156-
Password: password,
153+
Username: os.Getenv("ACCESS_KEY_ID"),
154+
Password: os.Getenv("SECRET_KEY"),
157155
}
158-
159156
err := crane.Push(image, imageDestination, crane.WithAuth(auth), crane.WithContext(ctx))
160157
if err != nil {
161158
log.Fatalf("Error pushing image: %v", err)

tasks/kubevirt-disk-uploader/0.5.0/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ metadata:
3333
name: kubevirt-disk-uploader-credentials-tekton
3434
type: Opaque
3535
data:
36-
registryUsername: "<REGISTRY_USERNAME>"
37-
registryPassword: "<REGISTRY_PASSWORD>"
36+
accessKeyId: "<ACCESS_KEY_ID>"
37+
secretKey: "<SECRET_KEY>"
3838
```
3939

4040
TaskRun:

tasks/kubevirt-disk-uploader/0.5.0/kubevirt-disk-uploader.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,16 @@ spec:
3232
- name: kubevirt-disk-uploader-step
3333
image: quay.io/boukhano/kubevirt-disk-uploader:v0.5.0
3434
env:
35-
- name: REGISTRY_USERNAME
35+
- name: ACCESS_KEY_ID
3636
valueFrom:
3737
secretKeyRef:
3838
name: kubevirt-disk-uploader-credentials-tekton
39-
key: registryUsername
40-
- name: REGISTRY_PASSWORD
39+
key: accessKeyId
40+
- name: SECRET_KEY
4141
valueFrom:
4242
secretKeyRef:
4343
name: kubevirt-disk-uploader-credentials-tekton
44-
key: registryPassword
44+
key: secretKey
4545
- name: VM_NAMESPACE
4646
valueFrom:
4747
fieldRef:

tasks/kubevirt-disk-uploader/0.5.0/tests/kubevirt-disk-uploader-secret.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ metadata:
55
name: kubevirt-disk-uploader-credentials-tekton
66
type: Opaque
77
data:
8-
registryUsername: "<REGISTRY_USERNAME>"
9-
registryPassword: "<REGISTRY_PASSWORD>"
8+
accessKeyId: "<ACCESS_KEY_ID>"
9+
secretKey: "<SECRET_KEY>"

0 commit comments

Comments
 (0)