-
Notifications
You must be signed in to change notification settings - Fork 717
fix: go-license dependency and fixes for provenance/sbom tests. #4318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: go-license dependency and fixes for provenance/sbom tests. #4318
Conversation
a4dc8c9 to
690b54d
Compare
a2ba060 to
33fc1d3
Compare
a8f0c38 to
5cecd6a
Compare
|
I have opened this PR: google/go-licenses#330 to update go-licenses package. |
e90a40e to
408f745
Compare
0bf1c36 to
4ff81d9
Compare
|
Flaky Tests:
|
|
@apostasie for networking i think there is some level of path concurrency or regex check for nat is happening. seems flaky so likely concurrency. what do you think? |
If something is flaky, we should list it in there: #4120 BuiltAttestation is a bit more worrisome. |
4ff81d9 to
3b3caca
Compare
|
For provenance and sbom they started adding platform info so needed a regex. its not flaky. |
|
@AkihiroSuda can i get an approval for this. |
|
@Shubhranshu153 thanks for taking care of this. Maybe, ideally, we would have two separate commits? (one for go 1.24 compat, and the other one for build attestation change?) Otherwise LGTM. |
Signed-off-by: shubhranshu153 <[email protected]>
Signed-off-by: shubhranshu153 <[email protected]>
3b3caca to
0eee948
Compare
|
Split the commits. |
AkihiroSuda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Testing if this fixes go-license issue.