Merge pull request #847 from giuseppe/function-attributes

add some function attributes

Author: giuseppe

src/libcrun/container.c

@@ -1683,7 +1683,7 @@ write_container_status (libcrun_container_t *container, libcrun_context_t *conte
     .scope = NULL,
   };
 
-  get_current_timestamp (created);
+  get_current_timestamp (created, sizeof (created));
 
   if (cwd == NULL)
     OOM ();

src/libcrun/error.h

@@ -77,11 +77,11 @@ int crun_error_release (libcrun_error_t *err);
 
 void crun_error_write_warning_and_release (FILE *out, libcrun_error_t **err);
 
-LIBCRUN_PUBLIC void libcrun_warning (const char *msg, ...);
+LIBCRUN_PUBLIC void libcrun_warning (const char *msg, ...) __attribute__ ((format (printf, 1, 2)));
 
-LIBCRUN_PUBLIC void libcrun_error (int errno_, const char *msg, ...);
+LIBCRUN_PUBLIC void libcrun_error (int errno_, const char *msg, ...) __attribute__ ((format (printf, 2, 3)));
 
-LIBCRUN_PUBLIC int libcrun_make_error (libcrun_error_t *err, int status, const char *msg, ...);
+LIBCRUN_PUBLIC int libcrun_make_error (libcrun_error_t *err, int status, const char *msg, ...) __attribute__ ((format (printf, 3, 4)));
 
 LIBCRUN_PUBLIC void libcrun_error_write_warning_and_release (FILE *out, libcrun_error_t **err);
 

src/libcrun/utils.c

@@ -1605,7 +1605,7 @@ mark_or_close_fds_ge_than (int n, bool close_now, libcrun_error_t *err)
 }
 
 void
-get_current_timestamp (char *out)
+get_current_timestamp (char *out, size_t len)
 {
   struct timeval tv;
   struct tm now;
@@ -1615,7 +1615,8 @@ get_current_timestamp (char *out)
   gmtime_r (&tv.tv_sec, &now);
   strftime (timestamp, sizeof (timestamp), "%Y-%m-%dT%H:%M:%S", &now);
 
-  sprintf (out, "%s.%09ldZ", timestamp, tv.tv_usec);
+  snprintf (out, len, "%s.%09ldZ", timestamp, tv.tv_usec);
+  out[len - 1] = '\0';
 }
 
 int

src/libcrun/utils.h

@@ -54,7 +54,7 @@
 #define LIKELY(x) __builtin_expect ((x), 1)
 #define UNLIKELY(x) __builtin_expect ((x), 0)
 
-static inline void *
+__attribute__ ((malloc)) static inline void *
 xmalloc (size_t size)
 {
   void *res = malloc (size);
@@ -63,7 +63,7 @@ xmalloc (size_t size)
   return res;
 }
 
-static inline void *
+__attribute__ ((malloc)) static inline void *
 xmalloc0 (size_t size)
 {
   void *res = calloc (1, size);
@@ -72,7 +72,7 @@ xmalloc0 (size_t size)
   return res;
 }
 
-static inline void *
+__attribute__ ((malloc)) static inline void *
 xrealloc (void *ptr, size_t size)
 {
   void *res = realloc (ptr, size);
@@ -223,7 +223,7 @@ path_is_slash_dev (const char *path)
   return true;
 }
 
-int xasprintf (char **str, const char *fmt, ...);
+int xasprintf (char **str, const char *fmt, ...) __attribute__ ((format (printf, 2, 3)));
 
 int crun_path_exists (const char *path, libcrun_error_t *err);
 
@@ -302,7 +302,7 @@ int run_process_with_stdin_timeout_envp (char *path, char **args, const char *cw
 
 int mark_or_close_fds_ge_than (int n, bool close_now, libcrun_error_t *err);
 
-void get_current_timestamp (char *out);
+void get_current_timestamp (char *out, size_t len);
 
 int set_blocking_fd (int fd, int blocking, libcrun_error_t *err);
 
@@ -336,7 +336,7 @@ int safe_openat (int dirfd, const char *rootfs, size_t rootfs_len, const char *p
 
 ssize_t safe_write (int fd, const void *buf, ssize_t count);
 
-int append_paths (char **out, libcrun_error_t *err, ...);
+int append_paths (char **out, libcrun_error_t *err, ...) __attribute__ ((sentinel));
 
 int str2sig (const char *name);