Skip to content

Conversation

@ethan-ozelius-contentful
Copy link
Contributor

@ethan-ozelius-contentful ethan-ozelius-contentful commented Nov 13, 2025

This reverts commit b2ba23a, in PR 2587

I'm not exactly sure why this update broke the npm run check:browser script, but unfortunately it did and the error is not very helpful.

> [email protected] check:browser
> es-check es2018 ./dist/contentful.browser.js

error: ES-Check: there were 1 ES version matching errors.
info: 
          ES-Check Error:
          ----
          · erroring file: ./dist/contentful.browser.js
          · error: SyntaxError: Unexpected token (7140:11)
          · see the printed err.stack below for context
          ----

          SyntaxError: Unexpected token (7140:11)
    at pp$4.raise (/home/circleci/project/node_modules/acorn/dist/acorn.js:3573:15)
    at pp$9.unexpected (/home/circleci/project/node_modules/acorn/dist/acorn.js:772:10)
    at pp$8.parseTryStatement (/home/circleci/project/node_modules/acorn/dist/acorn.js:1169:51)
    at pp$8.parseStatement (/home/circleci/project/node_modules/acorn/dist/acorn.js:923:36)
    at pp$8.parseBlock (/home/circleci/project/node_modules/acorn/dist/acorn.js:1254:23)
    at pp$5.parseFunctionBody (/home/circleci/project/node_modules/acorn/dist/acorn.js:3391:24)
    at pp$8.parseFunction (/home/circleci/project/node_modules/acorn/dist/acorn.js:1376:10)
    at pp$8.parseFunctionStatement (/home/circleci/project/node_modules/acorn/dist/acorn.js:1070:17)
    at pp$8.parseStatement (/home/circleci/project/node_modules/acorn/dist/acorn.js:915:19)
    at pp$8.parseBlock (/home/circleci/project/node_modules/acorn/dist/acorn.js:1254:23)
        
Exited with code exit status 1

This actually DID fail the circleCI check which prevented it from being merged, but that branch protection was removed as part of the migration from circleCI to Github actions. And before the equivalent github action was added back, the PR was merged. 😲

This error is not occurring locally, so it needs more investigation, but in the meantime to resolve the main branch, reverting this commit.

@ethan-ozelius-contentful ethan-ozelius-contentful changed the title Revert "build(deps-dev): bump the dev-dependencies group across 1 dir… Revert a dependabot PR that broke babel/rollup builds for CI/CD browser [DX-505] Nov 13, 2025
@ethan-ozelius-contentful ethan-ozelius-contentful marked this pull request as ready for review November 13, 2025 16:48
@ethan-ozelius-contentful ethan-ozelius-contentful requested a review from a team November 13, 2025 16:59
@ethan-ozelius-contentful ethan-ozelius-contentful merged commit 9e98404 into master Nov 13, 2025
23 checks passed
@ethan-ozelius-contentful ethan-ozelius-contentful deleted the revert-dependabot-pr-2587 branch November 13, 2025 18:12
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.8.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants