Skip to content

Linting enabled by default #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beta-ziliani wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Linting enabled by default #642

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a935d0
Linting enabled by default
beta-ziliani Sep 28, 2022
997dac6
fixing netlify deploy
beta-ziliani Sep 28, 2022
14aef86
d'oh
beta-ziliani Sep 28, 2022
722a4a3
Update netlify.toml
beta-ziliani Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-book.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Populate sample version of Crystal
run: crystal --version | tee crystal-version.txt
- name: Build book
run: LINT=true make build
run: make build
- name: Configure AWS Credentials
if: github.event_name == 'push' && steps.branch.outputs.branch != null && github.repository == 'crystal-lang/crystal-book'
uses: aws-actions/configure-aws-credentials@v1
Expand Down
2 changes: 1 addition & 1 deletion mkdocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ plugins:
governance.md: https://crystal-lang.org/community/governance
platform_support.md: syntax_and_semantics/platform_support.md
- code-validator:
enabled: !ENV [LINT, false]
enabled: !ENV [LINT, true]
identifiers:
crystal:
validators:
Expand Down
2 changes: 2 additions & 0 deletions netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
command = "mkdocs build -d site --strict"
publish = "site/"

[context.deploy-preview.environment]
LINT = "false"