Removed unique constraint on public links

Author: glpatcern

pkg/share/manager/sql/model/model.go

@@ -106,34 +106,33 @@ type BaseModel struct {
 	ShareId   ShareID `gorm:"foreignKey:Id;references:ID;constraint:OnDelete:CASCADE"` //;references:ID
 	CreatedAt time.Time
 	UpdatedAt time.Time
-	DeletedAt gorm.DeletedAt `gorm:"uniqueIndex:u_share;uniqueIndex:u_link;uniqueIndex:u_ocmshare"`
+	DeletedAt gorm.DeletedAt `gorm:"uniqueIndex:u_share;uniqueIndex:u_ocmshare"`
 }
 
 // ProtoShare contains fields that are common between PublicLinks and Shares.
 type ProtoShare struct {
 	BaseModel
 	UIDOwner     string   `gorm:"size:64"`
-	UIDInitiator string   `gorm:"size:64;uniqueIndex:u_link"`
+	UIDInitiator string   `gorm:"size:64;uniqueIndex:u_share"`
 	ItemType     ItemType `gorm:"size:16;index"` // file | folder | reference | symlink
 	InitialPath  string
-	Inode        string `gorm:"size:32;uniqueIndex:u_share;uniqueIndex:u_link"`
-	Instance     string `gorm:"size:32;uniqueIndex:u_share;uniqueIndex:u_link"`
-	Permissions  uint8  `gorm:"uniqueIndex:u_share;uniqueIndex:u_link"`
+	Inode        string `gorm:"size:32;uniqueIndex:u_share"`
+	Instance     string `gorm:"size:32;uniqueIndex:u_share"`
+	Permissions  uint8  `gorm:"uniqueIndex:u_share"`
 	Orphan       bool
 	Expiration   datatypes.NullTime
 }
 
 // Share is a regular share between users or groups. The unique index ensures that there
-// can only be one share per (inode, instance, permissions, recipient) tuple, unless the share is deleted.
+// can only be one share per (initiator, inode, instance, permissions, recipient) tuple, unless the share is deleted.
 type Share struct {
 	ProtoShare
 	ShareWith         string `gorm:"size:255;uniqueIndex:u_share"` // 255 because this can be an external account, which has a long representation
 	SharedWithIsGroup bool
 	Description       string `gorm:"size:1024"`
 }
 
-// PublicLink is a public link share. The unique index ensures that there
-// can only be one public link per (initiator, inode, instance, permissions) tuple, unless the link is deleted.
+// PublicLink is a public link share. No unique constraints are enforced beyond the token.
 type PublicLink struct {
 	ProtoShare
 	// Current tokens are only 16 chars long, but old tokens used to be 32 characters