debug: deploy overwhelming debug firepower (PRINTs everywhere)

Every single step will be logged

Author: MahdiBaghbani

internal/grpc/services/gateway/storageprovider.go

@@ -477,6 +477,13 @@ func (s *svc) Unlock(ctx context.Context, req *provider.UnlockRequest) (*provide
 
 func (s *svc) Stat(ctx context.Context, req *provider.StatRequest) (*provider.StatResponse, error) {
 	log := appctx.GetLogger(ctx)
+	
+	log.Debug().
+		Str("path", req.Ref.GetPath()).
+		Str("storage_id", req.Ref.GetResourceId().GetStorageId()).
+		Str("opaque_id", req.Ref.GetResourceId().GetOpaqueId()).
+		Msg("gateway: Stat request")
+	
 	providers, err := s.findProviders(ctx, req.Ref)
 	if err != nil {
 		return &provider.StatResponse{
@@ -485,8 +492,17 @@ func (s *svc) Stat(ctx context.Context, req *provider.StatRequest) (*provider.St
 	}
 	providers = getUniqueProviders(providers)
 
+	log.Debug().
+		Int("num_providers", len(providers)).
+		Msg("gateway: found storage providers")
+
 	resPath := req.Ref.GetPath()
 	if len(providers) == 1 && (utils.IsRelativeReference(req.Ref) || resPath == "" || strings.HasPrefix(resPath, providers[0].ProviderPath)) {
+		log.Debug().
+			Str("provider_address", providers[0].Address).
+			Str("provider_path", providers[0].ProviderPath).
+			Msg("gateway: routing Stat to storage provider")
+		
 		c, err := s.getStorageProviderClient(ctx, providers[0])
 		if err != nil {
 			return &provider.StatResponse{
@@ -498,6 +514,14 @@ func (s *svc) Stat(ctx context.Context, req *provider.StatRequest) (*provider.St
 			log.Error().Err(err).Msg("Failed to stat " + resPath)
 			return rsp, err
 		}
+		
+		log.Debug().
+			Str("storage_id", rsp.Info.Id.StorageId).
+			Str("space_id", rsp.Info.Id.SpaceId).
+			Str("opaque_id", rsp.Info.Id.OpaqueId).
+			Str("path", rsp.Info.Path).
+			Msg("gateway: Stat response from storage provider")
+		
 		return rsp, nil
 	}
 

internal/http/services/owncloud/ocdav/meta.go

@@ -21,6 +21,7 @@ package ocdav
 import (
 	"net/http"
 
+	"github.com/cs3org/reva/v3/pkg/appctx"
 	"github.com/cs3org/reva/v3/pkg/rhttp/router"
 	"github.com/cs3org/reva/v3/pkg/spaces"
 )
@@ -38,13 +39,21 @@ func (h *MetaHandler) init(c *Config) error {
 // Handler handles requests.
 func (h *MetaHandler) Handler(s *svc) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		ctx := r.Context()
+		log := appctx.GetLogger(ctx)
+		
 		var id string
 		id, r.URL.Path = router.ShiftPath(r.URL.Path)
 		if id == "" {
 			http.Error(w, "400 Bad Request", http.StatusBadRequest)
 			return
 		}
 
+		log.Debug().
+			Str("raw_id", id).
+			Str("url_path", r.URL.Path).
+			Msg("meta: received resource ID from Web UI")
+
 		rid, ok := spaces.ParseResourceID(id)
 		if !ok {
 			// If this fails, client might be non-spaces
@@ -56,10 +65,21 @@ func (h *MetaHandler) Handler(s *svc) http.Handler {
 			}
 		}
 
+		log.Debug().
+			Str("storage_id", rid.StorageId).
+			Str("space_id", rid.SpaceId).
+			Str("opaque_id", rid.OpaqueId).
+			Msg("meta: parsed resource ID")
+
 		var head string
 		head, r.URL.Path = router.ShiftPath(r.URL.Path)
 		switch head {
 		case "v":
+			log.Debug().
+				Str("storage_id", rid.StorageId).
+				Str("space_id", rid.SpaceId).
+				Str("opaque_id", rid.OpaqueId).
+				Msg("meta: forwarding to versions handler")
 			h.VersionsHandler.Handler(s, rid).ServeHTTP(w, r)
 		default:
 			w.WriteHeader(http.StatusNotFound)

internal/http/services/owncloud/ocdav/propfind.go

@@ -820,10 +820,16 @@ func (s *svc) mdToPropResponse(ctx context.Context, pf *propfindXML, md *provide
 					if md.Id == nil {
 						propstatNotFound.Prop = append(propstatNotFound.Prop, s.newProp("oc:fileid", ""))
 					} else if spacesEnabled {
+						sublog.Debug().
+							Str("storage_id", md.Id.StorageId).
+							Str("space_id", md.Id.SpaceId).
+							Str("opaque_id", md.Id.OpaqueId).
+							Str("path", md.Path).
+							Msg("propfind: encoding fileid property")
 						// If our client uses spaces, we try to use the spaces-encoded file id (storage$base32(spacePath)!inode)
 						fileId, err := spaces.EncodeResourceInfo(md)
 						if err != nil {
-							log.Error().Err(err).Any("md", md).Msg("Failed to encode file id")
+							sublog.Error().Err(err).Any("md", md).Msg("Failed to encode file id")
 							propstatOK.Prop = append(propstatOK.Prop, s.newProp("oc:fileid", spaces.EncodeResourceID(md.Id)))
 						} else {
 							propstatOK.Prop = append(propstatOK.Prop, s.newProp("oc:fileid", fileId))
@@ -834,13 +840,24 @@ func (s *svc) mdToPropResponse(ctx context.Context, pf *propfindXML, md *provide
 
 				case "id": // desktop client only
 					if md.Id != nil {
+						sublog.Debug().
+							Str("storage_id", md.Id.StorageId).
+							Str("space_id", md.Id.SpaceId).
+							Str("opaque_id", md.Id.OpaqueId).
+							Str("path", md.Path).
+							Msg("propfind: encoding id property")
 						propstatOK.Prop = append(propstatOK.Prop, s.newProp("oc:id", spaces.EncodeResourceID(md.Id)))
 					} else {
 						propstatNotFound.Prop = append(propstatNotFound.Prop, s.newProp("oc:id", ""))
 					}
 				case "file-parent":
 					if md.ParentId != nil {
 						if spacesEnabled {
+							sublog.Debug().
+								Str("parent_storage_id", md.ParentId.StorageId).
+								Str("parent_space_id", md.ParentId.SpaceId).
+								Str("parent_opaque_id", md.ParentId.OpaqueId).
+								Msg("propfind: encoding file-parent property")
 							propstatOK.Prop = append(propstatOK.Prop, s.newProp("oc:file-parent", spaces.EncodeResourceID(md.ParentId)))
 						} else {
 							propstatOK.Prop = append(propstatOK.Prop, s.newProp("oc:file-parent", spaces.ResourceIdToString(md.ParentId)))

internal/http/services/owncloud/ocdav/versions.go

@@ -57,6 +57,12 @@ func (h *VersionsHandler) Handler(s *svc, rid *provider.ResourceId) http.Handler
 			return
 		}
 
+		log.Debug().
+			Str("storage_id", rid.StorageId).
+			Str("space_id", rid.SpaceId).
+			Str("opaque_id", rid.OpaqueId).
+			Msg("versions: handler entry - received rid")
+
 		// baseURI is encoded as part of the response payload in href field
 		baseURI := path.Join(ctx.Value(ctxKeyBaseURI).(string), spaces.EncodeResourceID(rid))
 		ctx = context.WithValue(ctx, ctxKeyBaseURI, baseURI)
@@ -180,6 +186,13 @@ func (h *VersionsHandler) doListVersions(w http.ResponseWriter, r *http.Request,
 	}
 
 	for i := range versions {
+		sublog.Debug().
+			Int("version_index", i).
+			Str("version_key", versions[i].GetKey()).
+			Str("rid_space_id", rid.SpaceId).
+			Str("info_id_space_id", info.Id.SpaceId).
+			Msg("versions: creating version ResourceInfo")
+		
 		vi := &provider.ResourceInfo{
 			// TODO(jfd) we cannot access version content, this will be a problem when trying to fetch version thumbnails
 			// Opaque
@@ -201,6 +214,14 @@ func (h *VersionsHandler) doListVersions(w http.ResponseWriter, r *http.Request,
 			Size:  versions[i].Size,
 			Owner: info.Owner,
 		}
+		
+		sublog.Debug().
+			Str("version_storage_id", vi.Id.StorageId).
+			Str("version_space_id", vi.Id.SpaceId).
+			Str("version_opaque_id", vi.Id.OpaqueId).
+			Str("version_path", vi.Path).
+			Msg("versions: created version ResourceInfo")
+		
 		infos = append(infos, vi)
 	}
 

pkg/spaces/utils.go

@@ -110,24 +110,37 @@ func EncodeResourceID(r *provider.ResourceId) string {
 // The resource ID is expected to be in the form of <storage_id>$base32(<path>)!<item_id>.
 func DecodeResourceID(raw string) (storageID, spacePath, itemID string, ok bool) {
 	// The input is expected to be in the form of <storage_id>$base32(<path>)!<item_id>
+	fmt.Fprintf(os.Stderr, "[DEBUG] DecodeResourceID: raw=%q\n", raw)
+	
 	s := strings.SplitN(raw, "!", 2)
 	if len(s) != 2 {
+		fmt.Fprintf(os.Stderr, "[DEBUG] DecodeResourceID: FAILED split (expected '!') raw=%q\n", raw)
 		return "", "", "", false
 	}
 	itemID = s[1]
 	storageID, spacePath, ok = DecodeStorageSpaceID(s[0])
+	
+	fmt.Fprintf(os.Stderr, "[DEBUG] DecodeResourceID: storageID=%q, spacePath=%q, itemID=%q, ok=%t\n",
+		storageID, spacePath, itemID, ok)
+	
 	return storageID, spacePath, itemID, ok
 }
 
 // ParseResourceID converts the encoded resource id in a CS3API ResourceId.
 func ParseResourceID(raw string) (*provider.ResourceId, bool) {
+	fmt.Fprintf(os.Stderr, "[DEBUG] ParseResourceID: raw=%q\n", raw)
+	
 	storageID, path, itemID, ok := DecodeResourceID(raw)
 	if !ok {
+		fmt.Fprintf(os.Stderr, "[DEBUG] ParseResourceID: FAILED decode raw=%q\n", raw)
 		return nil, false
 	}
 
 	spaceID := PathToSpaceID(path)
 
+	fmt.Fprintf(os.Stderr, "[DEBUG] ParseResourceID: storageID=%q, spaceID=%q (from path=%q), itemID=%q\n",
+		storageID, spaceID, path, itemID)
+
 	return &provider.ResourceId{
 		StorageId: storageID,
 		SpaceId:   spaceID,
@@ -141,11 +154,19 @@ func ParseResourceID(raw string) (*provider.ResourceId, bool) {
 // If no path or space_id is set, an error will be returned
 func EncodeResourceInfo(info *provider.ResourceInfo) (spaceId string, err error) {
 	if info.Id.SpaceId != "" {
-		return fmt.Sprintf("%s$%s!%s", info.Id.StorageId, info.Id.SpaceId, info.Id.OpaqueId), nil
+		result := fmt.Sprintf("%s$%s!%s", info.Id.StorageId, info.Id.SpaceId, info.Id.OpaqueId)
+		fmt.Fprintf(os.Stderr, "[DEBUG] EncodeResourceInfo: using existing spaceID=%q -> %q\n",
+			info.Id.SpaceId, result)
+		return result, nil
 	} else if info.Path != "" {
 		encodedPath := PathToSpaceID(info.Path)
-		return fmt.Sprintf("%s$%s!%s", info.Id.StorageId, encodedPath, info.Id.OpaqueId), nil
+		result := fmt.Sprintf("%s$%s!%s", info.Id.StorageId, encodedPath, info.Id.OpaqueId)
+		fmt.Fprintf(os.Stderr, "[DEBUG] EncodeResourceInfo: FALLBACK deriving spaceID from path=%q -> spaceID=%q -> %q\n",
+			info.Path, encodedPath, result)
+		return result, nil
 	} else {
+		fmt.Fprintf(os.Stderr, "[DEBUG] EncodeResourceInfo: FAILED no spaceID or path storageID=%q opaqueID=%q\n",
+			info.Id.StorageId, info.Id.OpaqueId)
 		return "", errors.New("resourceInfo must contain a spaceID or a path")
 	}
 }