Skip to content

Commit 37c2857

Browse files
committed
ci: fix flutter analysis with // ignore
1 parent 2d7ae0c commit 37c2857

File tree

8 files changed

+23
-3
lines changed

8 files changed

+23
-3
lines changed

example/lib/main.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@ class _AppState extends State<App> {
326326
return _registerFromCredentials(identity ?? "Unknown", token).then((value) {
327327
if (!value) {
328328
showDialog(
329+
// ignore: use_build_context_synchronously
329330
context: context,
330331
builder: (context) => const AlertDialog(
331332
title: Text("Error"),

example/lib/screens/widgets/state_toggle.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ class StateToggle extends StatelessWidget {
3131
padding: const EdgeInsets.all(8.0),
3232
child: Column(
3333
children: [
34+
// TODO(cybex-dev)
35+
// ignore: deprecated_member_use
3436
if (icon != null) Icon(icon, color: state ? iconColor : iconColor?.withOpacity(0.2) ?? Colors.grey),
3537
if (icon != null) const SizedBox(height: 8),
3638
Text(title, style: Theme.of(context).textTheme.bodySmall, textAlign: TextAlign.center),

lib/_internal/js/core/promise.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// TODO(cybex-dev) implement js_interop for js_util package
2+
// ignore: deprecated_member_use
13
import 'dart:js_util';
24

35
import 'package:js/js.dart';

lib/_internal/js/device/device.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ enum TwilioDeviceEvents {
2323
@JS("Twilio.Device")
2424
class Device extends Twilio {
2525
// private constructor
26-
// ignore: unused_element
26+
// ignore: unused_element_parameter, unused_element
2727
external Device._(token, [DeviceInitOptions? options]);
2828

2929
// factory used by js lib

lib/_internal/js/twilio.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
/// to call a specific JS function, add this inside the @JS annotation's parentheses e.g. [@JS("JSON.stringify")].
1717
/// Declare external functions that will be called from JS - keep JS and dart names synonymous - for readers, future devs, and debugging.
1818
/// These external functions are called from the main `plugin_name_web.dart` file.
19+
1920
@JS()
21+
// library directive must come first in file
2022
library twilio.js;
2123

2224
import 'package:js/js.dart';

lib/_internal/js/utils/js_object_utils.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import 'package:js/js.dart';
2+
// TODO(cybex-dev) implement js_interop for js_util package
3+
// ignore: deprecated_member_use
24
import 'package:js/js_util.dart';
35

46
Map<String, String> jsToStringMap(dynamic jsonObject) {

lib/_internal/twilio_loader.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
import 'dart:async';
2+
// TODO(cybex-dev) implement package:web
3+
// ignore: deprecated_member_use
24
import 'dart:html';
5+
// TODO(cybex-dev) implement dart:js_interop
6+
// ignore: deprecated_member_use
37
import 'dart:js';
48

59
import 'utils.dart';

lib/_internal/twilio_voice_web.dart

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,25 @@
11
import 'dart:async';
22
import 'dart:convert';
33
import 'dart:developer';
4+
// TODO(cybex-dev) implement package:web
5+
// ignore: deprecated_member_use
46
import 'dart:html' as html;
57

68
import 'package:flutter/foundation.dart';
79
import 'package:flutter_web_plugins/flutter_web_plugins.dart';
810

911
// Added as temporary measure till sky_engine includes js_util (allowInterop())
12+
// TODO(cybex-dev) implement js_interop for allowInterop function
13+
// ignore: deprecated_member_use
1014
import 'package:js/js.dart' as js;
15+
// TODO(cybex-dev) implement js_interop for js_util package
16+
// ignore: deprecated_member_use
1117
import 'package:js/js_util.dart' as js_util;
1218
import 'package:twilio_voice/_internal/js/call/call_status.dart';
1319

1420
// This is required for JS interop, do not remove even though linter complains
15-
// ignore: unused_import
21+
// TODO(cybex-dev) implement js_interop for js_util package
22+
// ignore: unused_import,deprecated_member_use
1623
import 'package:js/js_util.dart';
1724
import 'package:twilio_voice/_internal/platform_interface/twilio_voice_platform_interface.dart';
1825

@@ -905,7 +912,7 @@ class Call extends MethodChannelTwilioCall {
905912
/// On accept/answering (inbound) call
906913
/// Undocumented event: Ringing found in twilio-voice.js implementation: https://github.com/twilio/twilio-voice.js/blob/94ea6b6d8d1128ac5091f3a3bec4eae745e4d12f/lib/twilio/call.ts#L1355
907914
/// Documentation: https://www.twilio.com/docs/voice/sdks/javascript/twiliocall#accept-event
908-
// ignore: unused_element
915+
// ignore: unused_element_parameter
909916
void _onCallRinging({bool hasEarlyMedia = false}) {
910917
if (_jsCall != null) {
911918
final params = getCallParams(_jsCall!);

0 commit comments

Comments
 (0)