fix: Firefox installation script version string comparisons #1446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
Version string comparisons in factory/installScripts/firefox/install-firefox-version.js are flawed. They will fail if the version of Firefox exceeds
999.Change
Extract the major version of Firefox, and make numerical comparisons based on this.
The installation script factory/installScripts/firefox/install-firefox-version.js:
bz2toxz(de-)compression for Firefox>=135.x>=136.xonarm64FACTORY_VERSION7.0.07.0.1Verification
--no-cacheto repeat testFIREFOX_VERSION134.0134.0.2135.0135.0.1136.0136.0.4140.4.0esr144.0.2999.01000.0