Skip to content

Commit 42ef591

Browse files
refactor: no longer limit anonymous users on experience (#3298)
1 parent 0b0264d commit 42ef591

File tree

2 files changed

+3
-17
lines changed

2 files changed

+3
-17
lines changed

__tests__/schema/profile.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -185,17 +185,6 @@ describe('query userExperiences', () => {
185185
expect(res.data.userExperiences.pageInfo.hasNextPage).toBe(false);
186186
});
187187

188-
it('should return only 1 experience for non-logged-in user', async () => {
189-
loggedUser = null;
190-
191-
const res = await client.query(USER_EXPERIENCES_QUERY, {
192-
variables: { userId: '1' },
193-
});
194-
195-
expect(res.errors).toBeFalsy();
196-
expect(res.data.userExperiences.edges).toHaveLength(1);
197-
});
198-
199188
it('should return all fields for logged-in users', async () => {
200189
loggedUser = '1';
201190

src/schema/profile.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -236,11 +236,8 @@ export const resolvers = traceResolvers<unknown, AuthContext>({
236236
ctx,
237237
info,
238238
(nodeSize) =>
239-
!!ctx.userId &&
240239
userExperiencesPageGenerator.hasPreviousPage(page, nodeSize),
241-
(nodeSize) =>
242-
!!ctx.userId &&
243-
userExperiencesPageGenerator.hasNextPage(page, nodeSize),
240+
(nodeSize) => userExperiencesPageGenerator.hasNextPage(page, nodeSize),
244241
(node, index) =>
245242
userExperiencesPageGenerator.nodeToCursor(page, args, node, index),
246243
(builder) => {
@@ -259,8 +256,8 @@ export const resolvers = traceResolvers<unknown, AuthContext>({
259256
builder.queryBuilder
260257
.orderBy(`${builder.alias}."endedAt"`, 'DESC', 'NULLS FIRST')
261258
.addOrderBy(`${builder.alias}."startedAt"`, 'DESC')
262-
.limit(!ctx.userId ? 1 : getLimit({ limit: page.limit }))
263-
.offset(!ctx.userId ? 0 : page.offset);
259+
.limit(getLimit({ limit: page.limit }))
260+
.offset(page.offset);
264261

265262
return builder;
266263
},

0 commit comments

Comments
 (0)