refactor: use trigger for soft delete

Author: capJavert

__tests__/users.ts

@@ -126,6 +126,7 @@ import {
   UserTransactionProcessor,
   UserTransactionStatus,
 } from '../src/entity/user/UserTransaction';
+import { DeletedUser } from '../src/entity/user/DeletedUser';
 
 let con: DataSource;
 let app: FastifyInstance;
@@ -4195,6 +4196,21 @@ describe('mutation deleteUser', () => {
         .senderId,
     ).toEqual(ghostUser.id);
   });
+
+  it('should soft delete user', async () => {
+    loggedUser = '1';
+
+    const user = await con.getRepository(User).findOneBy({ id: '1' });
+
+    expect(user).not.toBeNull();
+
+    await client.mutate(MUTATION);
+
+    const deletedUser = await con
+      .getRepository(DeletedUser)
+      .findOneBy({ id: '1' });
+    expect(deletedUser).not.toBeNull();
+  });
 });
 
 describe('POST /v1/users/logout', () => {

src/common/user.ts

@@ -24,7 +24,6 @@ import { ForbiddenError } from 'apollo-server-errors';
 import { logger } from '../logger';
 import { CoresRole } from '../types';
 import { remoteConfig } from '../remoteConfig';
-import { DeletedUser } from '../entity/user/DeletedUser';
 import { UserTransaction } from '../entity/user/UserTransaction';
 
 export const deleteUser = async (
@@ -106,9 +105,6 @@ export const deleteUser = async (
         },
       );
       await entityManager.getRepository(User).delete(userId);
-      await entityManager.getRepository(DeletedUser).insert({
-        id: userId,
-      });
     });
     logger.info(
       {

src/cron/cleanZombieUsers.ts

@@ -2,7 +2,6 @@ import { Cron } from './cron';
 import { User } from '../entity';
 import { LessThan } from 'typeorm';
 import { subHours } from 'date-fns';
-import { DeletedUser } from '../entity/user/DeletedUser';
 
 const cron: Cron = {
   name: 'clean-zombie-users',
@@ -23,25 +22,9 @@ const cron: Cron = {
       ])
       .andWhere({
         createdAt: LessThan(timeThreshold),
-      })
-      .returning(['id']);
+      });
 
-    const { affected, raw } = await query.execute();
-
-    if (Array.isArray(raw) && raw.length > 0) {
-      await con
-        .createQueryBuilder()
-        .insert()
-        .into(DeletedUser)
-        .values(
-          raw.map((item: { id: string }) => {
-            return con.getRepository(DeletedUser).create({
-              id: item.id,
-            });
-          }),
-        )
-        .execute();
-    }
+    const { affected } = await query.execute();
 
     logger.info({ count: affected }, 'zombies users cleaned! 🧟');
   },

src/migration/1744965354822-DeletedUser.ts

@@ -7,9 +7,34 @@ export class DeletedUser1744965354822 implements MigrationInterface {
     await queryRunner.query(
       `CREATE TABLE "deleted_user" ("id" character varying(36) NOT NULL, "userDeletedAt" TIMESTAMP NOT NULL DEFAULT now(), CONSTRAINT "PK_e85dad6b83f0681a83fd04fe691" PRIMARY KEY ("id"))`,
     );
+
+    await queryRunner.query(`
+      CREATE OR REPLACE FUNCTION soft_delete_user()
+      RETURNS TRIGGER AS $$
+      BEGIN
+          INSERT INTO deleted_user (id) VALUES (OLD.id);
+          RETURN NULL;
+      END;
+      $$ LANGUAGE plpgsql;
+    `);
+
+    await queryRunner.query(`
+      CREATE OR REPLACE TRIGGER soft_delete_user_trigger
+      AFTER DELETE ON public.user
+      FOR EACH ROW
+      EXECUTE FUNCTION soft_delete_user();
+    `);
   }
 
   public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`
+      DROP TRIGGER IF EXISTS soft_delete_user_trigger ON public."user";
+    `);
+
+    await queryRunner.query(`
+      DROP FUNCTION IF EXISTS soft_delete_user();
+    `);
+
     await queryRunner.query(`DROP TABLE "deleted_user"`);
   }
 }