feat: error case tests

Author: capJavert

__tests__/common/njord.ts

@@ -756,6 +756,39 @@ describe('purchaseCores', () => {
       (clientSpy.mock.calls[0][1]!.headers as Headers).get('authorization'),
     ).toStartWith('Bearer ');
   });
+
+  it('should throw on njord error', async () => {
+    jest.spyOn(njordCommon, 'getNjordClient').mockImplementation(() =>
+      createClient(
+        Credits,
+        createMockNjordErrorTransport({
+          errorStatus: TransferStatus.INTERNAL_ERROR,
+        }),
+      ),
+    );
+
+    const transaction = await con.getRepository(UserTransaction).save({
+      processor: UserTransactionProcessor.Njord,
+      receiverId: 't-pc-2',
+      status: UserTransactionStatus.Success,
+      productId: null,
+      senderId: null,
+      value: 42,
+      valueIncFees: 42,
+      fee: 0,
+      request: {},
+      flags: {
+        note: 'Test test!',
+      },
+    });
+
+    await expect(
+      async () =>
+        await njordCommon.purchaseCores({
+          transaction,
+        }),
+    ).rejects.toBeInstanceOf(TransferError);
+  });
 });
 
 describe('createNjordAuth', () => {

__tests__/routes/webhooks/apple.ts

@@ -11,7 +11,11 @@ import {
   User,
   UserSubscriptionStatus,
 } from '../../../src/entity';
-import { createMockNjordTransport, saveFixtures } from '../../helpers';
+import {
+  createMockNjordErrorTransport,
+  createMockNjordTransport,
+  saveFixtures,
+} from '../../helpers';
 import {
   NotificationTypeV2,
   Subtype,
@@ -24,7 +28,7 @@ import { env } from 'process';
 import { deleteRedisKey, getRedisHash } from '../../../src/redis';
 import { StorageKey } from '../../../src/config';
 import { createClient } from '@connectrpc/connect';
-import { Credits } from '@dailydotdev/schema';
+import { Credits, TransferStatus } from '@dailydotdev/schema';
 import * as njordCommon from '../../..//src/common/njord';
 import { getTransactionForProviderId } from '../../../src/common/paddle';
 import { UserTransactionProcessor } from '../../../src/entity/user/UserTransaction';
@@ -555,5 +559,63 @@ describe('POST /webhooks/apple/notifications', () => {
       });
       expect(userTransaction).toBeNull();
     });
+
+    it('should error cores purchase on njord error', async () => {
+      jest.spyOn(njordCommon, 'getNjordClient').mockImplementation(() =>
+        createClient(
+          Credits,
+          createMockNjordErrorTransport({
+            errorStatus: TransferStatus.INSUFFICIENT_FUNDS,
+            errorMessage: 'Insufficient funds',
+          }),
+        ),
+      );
+
+      const purchaseCoresSpy = jest.spyOn(njordCommon, 'purchaseCores');
+
+      await request(app.server)
+        .post('/webhooks/apple/notifications')
+        .send({
+          signedPayload: signedPayload({
+            notificationType: NotificationTypeV2.ONE_TIME_CHARGE,
+            data: {
+              signedTransactionInfo: {
+                productId: 'cores_100',
+                quantity: 1,
+                type: 'Consumable',
+                appAccountToken: '18138f83-b4d3-456a-831f-1f3f7bcbb0bd',
+                transactionId: '220698',
+              },
+            },
+          }),
+        })
+        .expect(200);
+
+      expect(purchaseCoresSpy).toHaveBeenCalledTimes(1);
+
+      const userTransaction = await getTransactionForProviderId({
+        con,
+        providerId: '220698',
+      });
+
+      expect(userTransaction).toEqual({
+        id: expect.any(String),
+        createdAt: expect.any(Date),
+        fee: 0,
+        flags: {
+          providerId: '220698',
+          error: 'Insufficient Cores balance.',
+        },
+        processor: UserTransactionProcessor.AppleStoreKit,
+        productId: null,
+        receiverId: 'storekit-user-c-1',
+        request: {},
+        senderId: null,
+        status: 1,
+        updatedAt: expect.any(Date),
+        value: 100,
+        valueIncFees: 100,
+      });
+    });
   });
 });

__tests__/routes/webhooks/paddle.ts

@@ -1,6 +1,10 @@
 import { DataSource } from 'typeorm';
 import createOrGetConnection from '../../../src/db';
-import { createMockNjordTransport, saveFixtures } from '../../helpers';
+import {
+  createMockNjordErrorTransport,
+  createMockNjordTransport,
+  saveFixtures,
+} from '../../helpers';
 import { SubscriptionProvider, User } from '../../../src/entity';
 import { usersFixture } from '../../fixture';
 
@@ -26,7 +30,7 @@ import { logger } from '../../../src/logger';
 import { CoresRole } from '../../../src/types';
 import * as njordCommon from '../../../src/common/njord';
 import { createClient } from '@connectrpc/connect';
-import { Credits } from '@dailydotdev/schema';
+import { Credits, TransferStatus } from '@dailydotdev/schema';
 
 let con: DataSource;
 
@@ -586,4 +590,48 @@ describe('cores product', () => {
     expect(userTransaction!.status).toBe(202);
     expect(userTransaction!.flags.error).toBeNull();
   });
+
+  it('transaction njord error on completed', async () => {
+    jest.spyOn(njordCommon, 'getNjordClient').mockImplementation(() =>
+      createClient(
+        Credits,
+        createMockNjordErrorTransport({
+          errorStatus: TransferStatus.INSUFFICIENT_FUNDS,
+          errorMessage: 'Insufficient funds',
+        }),
+      ),
+    );
+
+    const purchaseCoresSpy = jest.spyOn(njordCommon, 'purchaseCores');
+
+    await processTransactionCompleted({ event: coresTransactionCompleted });
+
+    expect(purchaseCoresSpy).toHaveBeenCalledTimes(1);
+
+    const userTransaction = await getTransactionForProviderId({
+      con,
+      providerId: coresTransactionCompleted.data.id,
+    });
+
+    expect(userTransaction).not.toBeNull();
+
+    expect(userTransaction).toEqual({
+      id: expect.any(String),
+      createdAt: expect.any(Date),
+      fee: 0,
+      flags: {
+        providerId: 'txn_01jrwyswhztmre55nbd7d09qvp',
+        error: 'Insufficient Cores balance.',
+      },
+      processor: 'paddle',
+      productId: null,
+      receiverId: 'whcp-1',
+      request: {},
+      senderId: null,
+      status: 1,
+      updatedAt: expect.any(Date),
+      value: 600,
+      valueIncFees: 600,
+    });
+  });
 });

src/routes/webhooks/paddle.ts

@@ -29,6 +29,7 @@ import { logger } from '../../logger';
 import {
   AnalyticsEventName,
   sendAnalyticsEvent,
+  TargetType,
 } from '../../integrations/analytics';
 import { JsonContains, type DataSource, type EntityManager } from 'typeorm';
 import {
@@ -278,7 +279,9 @@ const logPaddleAnalyticsEvent = async (
       app_platform: 'api',
       user_id: userId,
       extra: JSON.stringify(getAnalyticsExtra(data)),
-      target_type: isCoreTransaction({ event }) ? 'credits' : 'plus',
+      target_type: isCoreTransaction({ event })
+        ? TargetType.Credits
+        : TargetType.Plus,
     },
   ]);
 };