-
Notifications
You must be signed in to change notification settings - Fork 110
feat: parse cv to profile #3297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3a0a134
feat: parse cv to profile
capJavert d95c753
feat: add support for os and volunteering
capJavert 7b66c4a
feat: tests
capJavert 8e955e1
feat: register worker
capJavert ef2921a
Merge branch 'main' into parse-cv-profile
capJavert 5b1b383
chore: disable worker for now in prod
capJavert 98c5ec3
fix: cv parse date from cdc
capJavert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| import { | ||
| BrokkrParseRequest, | ||
| CandidatePreferenceUpdated, | ||
| } from '@dailydotdev/schema'; | ||
| import type { TypedWorker } from '../worker'; | ||
| import { User } from '../../entity/user/User'; | ||
| import { getBrokkrClient } from '../../common/brokkr'; | ||
| import { updateFlagsStatement } from '../../common/utils'; | ||
| import { importUserExperienceFromJSON } from '../../common/profile/import'; | ||
|
|
||
| export const parseCVProfileWorker: TypedWorker<'api.v1.candidate-preference-updated'> = | ||
| { | ||
| subscription: 'api.parse-cv-profile', | ||
| parseMessage: ({ data }) => CandidatePreferenceUpdated.fromBinary(data), | ||
| handler: async ({ data }, con) => { | ||
| const { userId, cv } = data.payload || {}; | ||
|
|
||
| if (!cv?.blob || !cv?.bucket) { | ||
| return; | ||
| } | ||
|
|
||
| if (!cv?.lastModified) { | ||
| return; | ||
| } | ||
|
|
||
| if (!userId) { | ||
| return; | ||
| } | ||
|
|
||
| const user: Pick<User, 'flags'> | null = await con | ||
| .getRepository(User) | ||
| .findOne({ | ||
| select: ['flags'], | ||
| where: { | ||
| id: userId, | ||
| }, | ||
| }); | ||
|
|
||
| if (!user) { | ||
| return; | ||
| } | ||
|
|
||
| const lastModifiedCVDate = new Date(cv.lastModified); | ||
|
|
||
| if (Number.isNaN(lastModifiedCVDate.getTime())) { | ||
| return; | ||
| } | ||
|
|
||
| const lastProfileParseDate = user.flags.lastCVParseAt || new Date(0); | ||
|
|
||
| if (lastModifiedCVDate <= lastProfileParseDate) { | ||
| return; | ||
| } | ||
|
|
||
| const brokkrClient = getBrokkrClient(); | ||
|
|
||
| try { | ||
| await con.getRepository(User).update( | ||
| { id: userId }, | ||
| { | ||
| flags: updateFlagsStatement<User>({ | ||
| lastCVParseAt: new Date(), | ||
| }), | ||
| }, | ||
| ); | ||
|
|
||
| const result = await brokkrClient.garmr.execute(() => { | ||
| return brokkrClient.instance.parseCV( | ||
| new BrokkrParseRequest({ | ||
| bucketName: cv.bucket, | ||
| blobName: cv.blob, | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| const dataJson = JSON.parse(result.parsedCv); | ||
|
|
||
| await importUserExperienceFromJSON({ | ||
| con: con.manager, | ||
| dataJson, | ||
| userId, | ||
| }); | ||
| } catch (error) { | ||
| // revert to previous date on error | ||
| await con.getRepository(User).update( | ||
| { id: userId }, | ||
| { | ||
| flags: updateFlagsStatement<User>({ | ||
| lastCVParseAt: user.flags.lastCVParseAt, | ||
| }), | ||
| }, | ||
| ); | ||
|
|
||
| throw error; | ||
| } | ||
| }, | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just moved to
common/profilefor reuse