bignum tests

Author: danielaparker

CHANGELOG.md

@@ -13,19 +13,28 @@
       `basic_csv_parser` `basic_csv_reader` and `basic_csv_cursor` that take an `err_handler` argument have been deprecated
       and will be removed in a future release. Use the `allow_trailing_comma` and `allow_comments`
       options instead.
+
     - The functors `strict_json_parsing` and `allow_trailing_commas have been deprecated and 
       will be removed in a future release. Use the `allow_trailing_comma` and `allow_comments` 
       options instead.
 
+    - The json_parser option `lossless_bignum`, when **false**, now applies to integer values as well as floating point values. 
+
+    - `basic_json::is_bignum` function has been changed to return `true` if the value 
+      is any string value tagged as `bigint`, `bigdec`, `float128`, or `bigfloat`
+      (previously only `bigint`.)
+
 - Enhancements
 
-    - Git Discussion #594: Supports `boost::optional` with built-in reflection traits
+    - Git Discussions #594: Updated reflection traits to supports `boost::optional` 
 
-    - Git Discussion #651: Improve `decode_json` error messages 
+    - Git Discussions #651: Improved `decode_json` error messages 
 
     - Git PR #647: Allow user configuration of **JSONCONS_HAS_STD_FROM_CHARS**
 
-    - Added an `indent_char` property to `basic_json_options` that supports tab indents
+    - Git Discussions #654: Added an `indent_char` property to `basic_json_options` that supports tab indents
+
+    - Git Discussions #660: Added reflection traits for read/write of enum values as integers.
 
 - Fixed bug:
 

doc/ref/corelib/basic_json_options.md

@@ -22,12 +22,12 @@ neginf_to_str|Substitute string with `negative infinity`, if enabled|Sets a stri
 nan_to_num| |Sets a number replacement for `NaN` when writing JSON|Unenabled|
 inf_to_num| |Sets a number replacement for `Infinity` when writing JSON|Unenabled|
 neginf_to_num| |Sets a number replacement for `Negative Infinity` when writing JSON|Unenabled|
-max_nesting_depth|Maximum nesting depth allowed when parsing JSON|Maximum nesting depth allowed when serializing JSON|1024|
+max_nesting_depth|Maximum nesting depth allowed when parsing JSON|Maximum nesting depth allowed when serializing JSON|**1024**|
 lossless_bignum|When parsing floating point values, and value is out-of-range, produces a string with tag `semantic_tag::bigdec` if **true**, otherwise produces +- infinity.| |**true**|(since 1.4.0)</br>(until 1.5.0)
-lossless_bignum|When parsing an integer value, and value is out-of-range, produces a string with tag `semantic_tag::bigint` if **true**, otherwise parses as double. When parsing floating point values, and value is out-of-range, produces a string with tag `semantic_tag::bigdec` if **true**, otherwise produces +- **infinity**.| |**true**|(since 1.5.0)
+lossless_bignum|When parsing an integer value, and value is out-of-range, produces a string with tag `semantic_tag::bigint` if **true**, otherwise parses as double. When parsing floating point values, and value is out-of-range, produces a string with tag `semantic_tag::bigdec` if **true**, otherwise produces `+- infinity`.| |**true**|(since 1.5.0)
 lossless_number|If **true**, reads numbers with exponents and fractional parts as strings with tag `semantic_tag::bigdec`.| |**false**|
 allow_comments|If 'true', allow (and ignore) comments when parsing JSON| |**true**|(since 1.3.0)
-allow_trailing_comma|If 'true', an extra comma at the end of a list of JSON values in an object or array is allowed (and ignored)| |false|(since 1.3.0)
+allow_trailing_comma|If 'true', an extra comma at the end of a list of JSON values in an object or array is allowed (and ignored)| |**false**|(since 1.3.0)
 err_handler|Defines an [error handler](err_handler.md) for parsing JSON.| |`default_json_parsing`|(since 0.171.0, deprecated in 1.5.0)
 indent_size| |The indent size|4|
 indent_char| |The indent character, e.g. '\t'|' '| (since 1.5)

test/corelib/src/json_options_tests.cpp

@@ -696,7 +696,7 @@ TEST_CASE("json_options lossless_bignum")
         j.dump(buffer);
         CHECK(expected == buffer);
     }
-    SECTION("positive bignum")
+    SECTION("negative bignum")
     {
         std::string str = R"({"a":-123456789012345678901234567890})";
         std::string expected = R"({"a":-1.2345678901234568e+29})";
@@ -707,5 +707,29 @@ TEST_CASE("json_options lossless_bignum")
         j.dump(buffer);
         CHECK(expected == buffer);
     }
+    SECTION("+inf")
+    {
+        std::string str = R"({"a":1e999})";
+        std::string expected = R"({"a":null})";
+        auto options = jsoncons::json_options{}
+            .lossless_bignum(false);
+        auto j = jsoncons::json::parse(str, options);
+        CHECK(HUGE_VAL == j["a"].as<double>());
+        std::string buffer;
+        j.dump(buffer);
+        CHECK(expected == buffer);
+    }
+    SECTION("-inf")
+    {
+        std::string str = R"({"a":-1e999})";
+        std::string expected = R"({"a":null})";
+        auto options = jsoncons::json_options{}
+            .lossless_bignum(false);
+        auto j = jsoncons::json::parse(str, options);
+        CHECK(-HUGE_VAL == j["a"].as<double>());
+        std::string buffer;
+        j.dump(buffer);
+        CHECK(expected == buffer);
+    }
 }