Merge pull request #4 from dantengsky/feat-setting-dist-copy

feat: new setting "enable_distributed_copy_into"

Author: JackTan25

src/query/service/tests/it/storages/testdata/settings_table.txt

@@ -8,6 +8,7 @@ DB.Table: 'system'.'settings', Table: settings-table_id:1, ver:0, Engine: System
 | 'efficiently_memory_group_by'           | '0'            | '0'            | 'SESSION' | 'Memory is used efficiently, but this may cause performance degradation.'                                                                                                             | 'UInt64' |
 | 'enable_bushy_join'                     | '0'            | '0'            | 'SESSION' | 'Enables generating a bushy join plan with the optimizer.'                                                                                                                            | 'UInt64' |
 | 'enable_cbo'                            | '1'            | '1'            | 'SESSION' | 'Enables cost-based optimization.'                                                                                                                                                    | 'UInt64' |
+| 'enable_distributed_copy_into'          | '1'            | '1'            | 'SESSION' | 'Enable distributed execution of copy into.'                                                                                                                                          | 'UInt64' |
 | 'enable_dphyp'                          | '1'            | '1'            | 'SESSION' | 'Enables dphyp join order algorithm.'                                                                                                                                                 | 'UInt64' |
 | 'enable_query_result_cache'             | '0'            | '0'            | 'SESSION' | 'Enables caching query results to improve performance for identical queries.'                                                                                                         | 'UInt64' |
 | 'enable_runtime_filter'                 | '0'            | '0'            | 'SESSION' | 'Enables runtime filter optimization for JOIN.'                                                                                                                                       | 'UInt64' |

src/query/settings/src/settings_default.rs

@@ -310,6 +310,12 @@ impl DefaultSettings {
                     possible_values: None,
                     display_in_show_settings: false,
                 }),
+                ("enable_distributed_copy_into", DefaultSettingValue {
+                    value: UserSettingValue::UInt64(1),
+                    desc: "Enable distributed execution of copy into.",
+                    possible_values: None,
+                    display_in_show_settings: true,
+                }),
             ]);
 
             Ok(Arc::new(DefaultSettings {

src/query/settings/src/settings_getter_setter.rs

@@ -362,4 +362,12 @@ impl Settings {
     pub fn set_deduplicate_label(&self, val: String) -> Result<()> {
         self.set_setting("deduplicate_label".to_string(), val)
     }
+
+    pub fn get_enable_distributed_copy(&self) -> Result<bool> {
+        Ok(self.try_get_u64("enable_distributed_copy_into")? != 0)
+    }
+
+    pub fn set_enable_distributed_copy(&self, val: bool) -> Result<()> {
+        self.try_set_u64("enable_distributed_copy_into", u64::from(val))
+    }
 }

src/query/sql/src/planner/optimizer/optimizer.rs

@@ -19,6 +19,7 @@ use common_ast::ast::ExplainKind;
 use common_catalog::table_context::TableContext;
 use common_exception::ErrorCode;
 use common_exception::Result;
+use tracing::info;
 
 use super::cost::CostContext;
 use super::format::display_memo;
@@ -138,7 +139,12 @@ pub fn optimize(
                     Some(_) => CopyPlan::IntoTable(into_table),
                     None => {
                         into_table.enable_distributed =
-                            opt_ctx.config.enable_distributed_optimization;
+                            opt_ctx.config.enable_distributed_optimization
+                                && ctx.get_settings().get_enable_distributed_copy()?;
+                        info!(
+                            "after optimization enable_distributed_copy? : {}",
+                            into_table.enable_distributed
+                        );
                         CopyPlan::IntoTable(into_table)
                     }
                 },