Reenable mac size checks (#1001)

* Reenable mac size checks

* Fix

* Upgrade native toolchain

* fix

* Fix export

* add changelog

* Fix export

Author: mosuem

.github/workflows/intl4x.yml

@@ -146,10 +146,10 @@ jobs:
         working-directory: pkgs/intl4x/example_native
         if: matrix.os == 'macos-latest'
         run: ./build/cli/macos_arm64/bundle/bin/example_native
+
       - name: Print file size and check limit for example_native (Mac)
         working-directory: pkgs/intl4x/example_native
-        # skip until https://github.com/dart-lang/i18n/issues/989 issue is resolved
-        if: matrix.os == 'macos-latest' && false 
+        if: matrix.os == 'macos-latest'
         run: |
           FILE_PATH="build/cli/macos_arm64/bundle/lib/libintl4x.dylib"
           FILE_SIZE=$(stat -f %z "$FILE_PATH")
@@ -236,10 +236,9 @@ jobs:
 
       - name: Print file size and check limit for example_native (Mac)
         working-directory: pkgs/intl4x/example_native
-        # skip until https://github.com/dart-lang/i18n/issues/989 issue is resolved
-        if: matrix.os == 'macos-latest' && false
+        if: matrix.os == 'macos-latest'
         run: |
-          FILE_PATH="build/cli/macos_arm64/bundle/lib/example_native"
+          FILE_PATH="build/cli/macos_arm64/bundle/lib/libintl4x.dylib"
           FILE_SIZE=$(stat -f %z "$FILE_PATH")
           echo "macOS executable size: $FILE_SIZE bytes"
           if [ "$FILE_SIZE" -gt 10485760 ]; then

pkgs/intl4x/CHANGELOG.md

@@ -4,6 +4,7 @@
 - Removing `EcmaPolicy`, fixing Locale printing, and other small clean-ups.
 - Update to `native_toolchain_c` v0.16.7.
 - Make package compatible to run on Windows again.
+- Update to `native_toolchain_c` v0.17.1.
 
 ## 0.12.2
 

pkgs/intl4x/hook/link.dart

@@ -91,7 +91,7 @@ ${usedSymbols?.join('\n')}
           input.config.code.targetOS == OS.windows
               ? const ['MSVCRT', 'ws2_32', 'userenv', 'ntdll']
               : const [],
-      linkerOptions: LinkerOptions.treeshake(symbols: usedSymbols),
+      linkerOptions: LinkerOptions.treeshake(symbolsToKeep: usedSymbols),
     ).run(
       input: input,
       output: output,

pkgs/intl4x/lib/case_mapping.dart

@@ -4,7 +4,7 @@
 
 import 'intl4x.dart';
 
-export 'src/case_mapping/case_mapping.dart';
+export 'src/case_mapping/case_mapping.dart' show CaseMapping;
 export 'src/locale/locale.dart';
 
 extension CaseMappingWithIntl4X on String {

pkgs/intl4x/lib/intl4x.dart

@@ -6,6 +6,7 @@ import 'case_mapping.dart';
 import 'collation.dart';
 import 'display_names.dart';
 import 'number_format.dart';
+import 'src/case_mapping/case_mapping.dart' show buildCaseMapping;
 import 'src/case_mapping/case_mapping_impl.dart';
 import 'src/collation/collation.dart';
 import 'src/collation/collation_impl.dart';
@@ -50,7 +51,7 @@ class Intl {
     : locale = locale ?? findSystemLocale();
 
   CaseMapping get caseMapping =>
-      CaseMapping(CaseMappingImpl.build(locale, localeMatcher));
+      buildCaseMapping(CaseMappingImpl.build(locale, localeMatcher));
 
   Collation collation([CollationOptions options = const CollationOptions()]) =>
       buildCollation(CollationImpl.build(locale, options, localeMatcher));

pkgs/intl4x/lib/src/case_mapping/case_mapping.dart

@@ -13,7 +13,7 @@ import 'case_mapping_impl.dart';
 class CaseMapping {
   final CaseMappingImpl _caseMappingImpl;
 
-  const CaseMapping(this._caseMappingImpl);
+  const CaseMapping._(this._caseMappingImpl);
 
   String toLowerCase(String input) {
     if (isInTest) {
@@ -31,3 +31,6 @@ class CaseMapping {
     }
   }
 }
+
+CaseMapping buildCaseMapping(CaseMappingImpl collationImpl) =>
+    CaseMapping._(collationImpl);

pkgs/intl4x/pubspec.yaml

@@ -25,10 +25,10 @@ dependencies:
   collection: ^1.19.1
   crypto: ^3.0.6
   ffi: ^2.1.4
-  hooks: ^0.19.5
+  hooks: ^0.20.0
   logging: ^1.3.0
   meta: ^1.17.0
-  native_toolchain_c: ^0.16.7
+  native_toolchain_c: ^0.17.1
   path: ^1.9.1
   record_use: ^0.4.1