Skip to content

Commit a3a7cb1

Browse files
authored
apply feedback
1 parent 8c4f8a3 commit a3a7cb1

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

pkgs/ffigen/CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@
99
- __Breaking change__: Certain synthetic USRs have been modified to ensure they
1010
cannot collide with real USRs. It's very unlikely that any user facing USRs
1111
are affected.
12-
- __Breaking change__: Dart const values will be generated for global variables marked const in C (e.g. static const int) instead of symbol lookups. This supports integers, doubles, and string literals. Including the variable name in the globals -> symbol-address configuration will still generate symbol lookups.
12+
- __Breaking change__: Dart const values will be generated for global variables
13+
marked const in C (e.g. static const int) instead of symbol lookups. This
14+
supports integers, doubles, and string literals. Including the variable name
15+
in the globals -> symbol-address configuration will still generate symbol
16+
lookups.
1317

1418

1519
## 20.1.1

pkgs/ffigen/test/header_parser_tests/static_const.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ static const MyBufferUsage MyBufferUsage_MapRead = 0x0000000000000001;
3131

3232
// Should be generated as Globals.
3333
static const char TEST_STRING_ARRAY[] = "test_array";
34-
int test_global;
34+
int test_global;

pkgs/ffigen/test/header_parser_tests/static_const_config.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@ headers:
99
entry-points:
1010
- static_const.h
1111
include-directives:
12-
- '**static_const.h'
12+
- '**static_const.h'
13+

0 commit comments

Comments
 (0)