WIP: [ffigen] Support concurrent tests

Author: liamappelbe

pkgs/ffigen/dart_test.yaml

@@ -1,5 +1,2 @@
 # This package uses dart:ffi.
 test_on: vm
-
-# https://github.com/dart-lang/native/issues/461
-concurrency: 1

pkgs/ffigen/lib/src/logger.dart

@@ -7,14 +7,16 @@ import 'dart:io';
 import 'package:logging/logging.dart';
 
 /// Creates a default logger that logs to stdout and stderr.
-Logger createDefaultLogger() {
+Logger createDefaultLogger([Level level = Level.INFO]) {
   final logger = Logger.detached('FFIgen');
-  logger.level = Level.INFO;
+  logger.level = level;
   logger.onRecord.listen((record) {
+    final levelStr = '[${record.level.name}]'.padRight(9);
+    final log = '$levelStr: ${record.message}';
     if (record.level >= Level.WARNING) {
-      stderr.writeln(record.message);
+      stderr.writeln(log);
     } else {
-      stdout.writeln(record.message);
+      stdout.writeln(log);
     }
     if (record.error != null) {
       stderr.writeln(record.error);

pkgs/ffigen/test/example_tests/libclang_example_test.dart

@@ -15,9 +15,6 @@ import '../test_utils.dart';
 
 void main() {
   group('example_test', () {
-    setUpAll(() {
-      logWarnings(Level.SEVERE);
-    });
     test('libclang-example', () {
       final configYaml = File(
         path.join(
@@ -27,12 +24,19 @@ void main() {
           'config.yaml',
         ),
       ).absolute;
-      late FfiGenerator generator;
-      late Library library;
-      withChDir(configYaml.path, () {
-        generator = testConfigFromPath(configYaml.path);
-        library = parse(testContext(generator));
-      });
+      final generator = testConfigFromPath(configYaml.path);
+
+      // The clang parser is run using the current working directory, and the
+      // libclang-example config relies on relative paths for one of its '-I'
+      // compiler options. It can't use absolute paths because it's checked in
+      // yaml code. To support concurrent tests, we can't set Directory.current.
+      // As a workaround, add an extra '-I' option that uses the absolute path.
+      generator.headers.compilerOptions!.add(
+        '-I${path.join(packagePathForTests, 'third_party/libclang/include')}'
+      );
+
+      final context = testContext(generator);
+      final library = parse(context);
 
       matchLibraryWithExpected(library, 'example_libclang.dart', [
         generator.output.dartFile.toFilePath(),

pkgs/ffigen/test/large_integration_tests/large_test.dart

@@ -5,6 +5,7 @@
 import 'package:ffigen/src/code_generator/imports.dart';
 import 'package:ffigen/src/config_provider/config.dart';
 import 'package:ffigen/src/config_provider/config_types.dart';
+import 'package:ffigen/src/context.dart';
 import 'package:ffigen/src/header_parser.dart';
 import 'package:logging/logging.dart';
 import 'package:path/path.dart' as path;
@@ -25,7 +26,7 @@ void main() {
         'include',
       );
       final logArr = <String>[];
-      logToArray(logArr, Level.SEVERE);
+      final logger = logToArray(logArr, Level.SEVERE);
       final generator = FfiGenerator(
         output: Output(
           dartFile: Uri.file('unused'),
@@ -75,7 +76,7 @@ void main() {
           imported: [ImportedType(ffiImport, 'Int64', 'int', 'time_t')],
         ),
       );
-      final library = parse(testContext(generator));
+      final library = parse(Context(logger, generator));
 
       matchLibraryWithExpected(
         library,

pkgs/ffigen/test/native_test/native_test.dart

@@ -42,10 +42,7 @@ void main() {
         ),
       ).absolute;
 
-      late FfiGenerator config;
-      withChDir(configFile.path, () {
-        config = testConfigFromPath(configFile.path);
-      });
+      final config = testConfigFromPath(configFile.path);
       final library = parse(testContext(config));
 
       library.generateFile(outFile);

pkgs/ffigen/test/test_utils.dart

@@ -11,6 +11,7 @@ import 'package:ffigen/src/config_provider/config.dart';
 import 'package:ffigen/src/config_provider/utils.dart';
 import 'package:ffigen/src/config_provider/yaml_config.dart';
 import 'package:ffigen/src/context.dart';
+import 'package:ffigen/src/logger.dart';
 import 'package:ffigen/src/visitor/ast.dart';
 import 'package:logging/logging.dart';
 import 'package:package_config/package_config_types.dart';
@@ -21,7 +22,7 @@ import 'package:yaml/yaml.dart' as yaml;
 export 'package:ffigen/src/config_provider/utils.dart';
 
 Context testContext([FfiGenerator? generator]) => Context(
-  Logger.root,
+  createDefaultLogger(Level.SEVERE),
   generator ?? FfiGenerator(output: Output(dartFile: Uri.file('unused'))),
 );
 
@@ -248,19 +249,4 @@ FfiGenerator testConfigFromPath(String path) {
   return testConfig(yamlBody, filename: path);
 }
 
-T withChDir<T>(String path, T Function() inner) {
-  final oldDir = Directory.current;
-  Directory.current = File(path).parent;
-
-  late T result;
-
-  try {
-    result = inner();
-  } finally {
-    Directory.current = oldDir;
-  }
-
-  return result;
-}
-
 bool isFlutterTester = Platform.resolvedExecutable.contains('flutter_tester');

pkgs/ffigen/tool/libclang_config.yaml

@@ -64,6 +64,7 @@ functions:
     - clang_getDiagnosticSeverity
     - clang_disposeDiagnostic
     - clang_parseTranslationUnit
+    - clang_parseTranslationUnit2FullArgv
     - clang_disposeTranslationUnit
     - clang_EvalResult_getKind
     - clang_EvalResult_getAsInt