Remove copyWith

Author: bkonyi

dwds/lib/dart_web_debug_service.dart

@@ -145,13 +145,16 @@ class Dwds {
       debugSettings.useSseForInjectedClient,
       debugSettings.expressionCompiler,
       injected,
-      debugSettings.ddsConfiguration.copyWith(
+      DartDevelopmentServiceConfiguration(
+        // This technically isn't correct, but DartDevelopmentServiceConfiguration.enable
+        // is true by default, so this won't break unmigrated tools.
         // ignore: deprecated_member_use_from_same_package
-        enable: debugSettings.spawnDds,
+        enable: debugSettings.spawnDds && debugSettings.ddsConfiguration.enable,
         // ignore: deprecated_member_use_from_same_package
-        port: debugSettings.ddsPort,
-        // TODO(bkonyi): only allow for DDS to serve DevTools.
-        devToolsServerAddress: launchedDevToolsUri,
+        port: debugSettings.ddsPort ?? debugSettings.ddsConfiguration.port,
+        devToolsServerAddress:
+            launchedDevToolsUri ??
+            debugSettings.ddsConfiguration.devToolsServerAddress,
       ),
       debugSettings.launchDevToolsInNewWindow,
       useWebSocketConnection: useDwdsWebSocketConnection,

dwds/lib/src/config/tool_configuration.dart

@@ -59,21 +59,6 @@ class DartDevelopmentServiceConfiguration {
     this.devToolsServerAddress,
   });
 
-  DartDevelopmentServiceConfiguration copyWith({
-    bool? enable,
-    int? port,
-    bool? serveDevTools,
-    Uri? devToolsServerAddress,
-  }) {
-    return DartDevelopmentServiceConfiguration(
-      enable: enable ?? this.enable,
-      port: port ?? this.port,
-      serveDevTools: serveDevTools ?? this.serveDevTools,
-      devToolsServerAddress:
-          devToolsServerAddress ?? this.devToolsServerAddress,
-    );
-  }
-
   final bool enable;
   final int? port;
   final bool serveDevTools;