Skip to content

Commit b90c7c2

Browse files
committed
fix: re-active cppcheck
The previous logic had an intersection of black & white list for exception, and only warnings that got in the white list have been shown. Everything that has not been matched with whitelist should be filtered by blacklist (exceptions), but not only whitelist matches
1 parent a9463b9 commit b90c7c2

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/lint/lint-cppcheck-dash.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,9 @@ def main():
132132

133133
unique_sorted_lines = sorted(set(dependencies_output.stdout.splitlines()))
134134
for line in unique_sorted_lines:
135-
if re.search(enabled_regexp, line) and not re.search(ignored_regexp, line) and re.search(files_regexp, line):
135+
if not re.search(files_regexp, line):
136+
continue
137+
if re.search(enabled_regexp, line) or not re.search(ignored_regexp, line):
136138
warnings.append(line)
137139

138140
if warnings:

0 commit comments

Comments
 (0)