fix: inverted flag usage of IsFullOutboundConn for bitcoin#19316, fixes dns probe connections

knst · knst · commit d2d66cf9e9b7 · 2025-12-01T03:42:40.000+07:00
diff --git a/src/net.cpp b/src/net.cpp
@@ -2680,7 +2680,7 @@ void CConnman::ThreadDNSAddressSeed()
                     {
                         READ_LOCK(m_nodes_mutex);
                         for (const CNode* pnode : m_nodes) {
-                            if (pnode->fSuccessfullyConnected && !pnode->IsFullOutboundConn() && !pnode->m_masternode_probe_connection) ++nRelevant;
+                            if (pnode->fSuccessfullyConnected && pnode->IsFullOutboundConn() && !pnode->m_masternode_probe_connection) ++nRelevant;
                         }
                     }
                     if (nRelevant >= 2) {

Original file line number	Diff line number	Diff line change
`@@ -2680,7 +2680,7 @@ void CConnman::ThreadDNSAddressSeed()`
`2680`	`2680`	`{`
`2681`	`2681`	`READ_LOCK(m_nodes_mutex);`
`2682`	`2682`	`for (const CNode* pnode : m_nodes) {`
`2683`		`- if (pnode->fSuccessfullyConnected && !pnode->IsFullOutboundConn() && !pnode->m_masternode_probe_connection) ++nRelevant;`
	`2683`	`+ if (pnode->fSuccessfullyConnected && pnode->IsFullOutboundConn() && !pnode->m_masternode_probe_connection) ++nRelevant;`
`2684`	`2684`	`}`
`2685`	`2685`	`}`
`2686`	`2686`	`if (nRelevant >= 2) {`