Skip to content

Commit 07518f2

Browse files
committed
fix conversation
1 parent 4e9b985 commit 07518f2

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/common/column/src/fixedsizebinary/builder.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,17 +71,13 @@ impl FixedSizeBinaryColumnBuilder {
7171
}
7272

7373
pub fn is_empty(&self) -> bool {
74-
self.len() <= 1
74+
self.len() < 1
7575
}
7676

7777
pub fn memory_size(&self) -> usize {
7878
self.data.len()
7979
}
8080

81-
pub fn put_u8(&mut self, item: u8) {
82-
self.data.push(item);
83-
}
84-
8581
pub fn push_default(&mut self) {
8682
self.data.extend_from_slice(&vec![0; self.value_length]);
8783
}

src/common/column/src/fixedsizebinary/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ impl FixedSizeBinaryColumn {
6868
}
6969

7070
pub fn index(&self, index: usize) -> Option<&[u8]> {
71-
if index + 1 < self.len() {
71+
if index < self.len() {
7272
Some(&self.data[index..index + self.value_length])
7373
} else {
7474
None

0 commit comments

Comments
 (0)