Skip to content

Commit 154664d

Browse files
authored
chore: remove fixeme on TimestampTz (#18924)
1 parent 5b874fa commit 154664d

File tree

5 files changed

+6
-12
lines changed

5 files changed

+6
-12
lines changed

tests/sqllogictests/suites/base/03_common/03_0016_insert_into_values.test

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,8 @@ create table if not exists ts1(a timestamp, b timestamp with time zone)
6868
statement ok
6969
insert into ts1 values (1676620596564, '2024-10-22 12:00:00+0900')
7070

71-
# FIXME: After Parser update then remove ::STRING
7271
query T
73-
select a, b::STRING from ts1
72+
select a, b from ts1
7473
----
7574
2023-02-17 07:56:36.564000 2024-10-22 21:00:00.000000 +0900
7675

tests/sqllogictests/suites/base/09_fuse_engine/09_0001_remote_insert.test

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,8 @@ CREATE TABLE IF NOT EXISTS t3(a Boolean, b Timestamp, c Date, d Array(Int), e Tu
5050
statement ok
5151
INSERT INTO t3 (a,b,c,d,e,f) values(true, '2021-09-07 21:38:35.000000', '2021-09-07', [1, 2, 3], (10, 'abc'), '2024-10-22 12:00:00+0900'), (false, 1631050715000000, 18877, [4, 5, 6], (20, 'xyz'), '2024-10-22 12:00:00');
5252

53-
# FIXME: After Parser update then remove ::STRING
5453
query BTTTTT
55-
SELECT a, b, c, d, e, f::string FROM t3 order by a desc;
54+
SELECT a, b, c, d, e, f FROM t3 order by a desc;
5655
----
5756
1 2021-09-07 21:38:35.000000 2021-09-07 [1,2,3] (10,'abc') 2024-10-22 21:00:00.000000 +0900
5857
0 2021-09-07 21:38:35.000000 2021-09-07 [4,5,6] (20,'xyz') 2024-10-22 12:00:00.000000 +0000
@@ -148,9 +147,8 @@ CREATE TABLE IF NOT EXISTS t_compression_zstd(a Boolean, b Timestamp, c Date, e
148147
statement ok
149148
INSERT INTO t_compression_zstd (a,b,c,e) values(true, '2021-09-07 21:38:35.000000', '2021-09-07', '2024-10-22 12:00:00+0900'), (false, 1631050715000000, 18877, '2024-10-22 12:00:00');
150149

151-
# FIXME: After Parser update then remove ::STRING
152150
query BTTT
153-
SELECT a, b, c, e::string FROM t_compression_zstd order by a desc;
151+
SELECT a, b, c, e FROM t_compression_zstd order by a desc;
154152
----
155153
1 2021-09-07 21:38:35.000000 2021-09-07 2024-10-22 21:00:00.000000 +0900
156154
0 2021-09-07 21:38:35.000000 2021-09-07 2024-10-22 12:00:00.000000 +0000

tests/sqllogictests/suites/base/11_data_type/11_0001_data_type_date_time.test

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,8 @@ select '2021-01-01T00:00:00+00:00'::timestamp = '2021-01-01T01:00:00+01:00'::tim
8181
----
8282
1
8383

84-
# FIXME: After Parser update then remove ::STRING
8584
query T
86-
select '2044-05-06 03:25:02.868894'::TIMESTAMP_TZ::STRING
85+
select '2044-05-06 03:25:02.868894'::TIMESTAMP_TZ
8786
----
8887
2044-05-06 03:25:02.868894 +0000
8988

tests/sqllogictests/suites/base/11_data_type/11_0005_data_type_date.test

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,8 @@ select '0099-05-16'::DATE
1616
----
1717
0099-05-16
1818

19-
# FIXME: After Parser update then remove ::STRING
2019
query T
21-
select '1022-05-16'::DATE, date '1022-05-16', timestamp '1022-05-16', (timestamp_tz '1022-05-16')::string
20+
select '1022-05-16'::DATE, date '1022-05-16', timestamp '1022-05-16', timestamp_tz '1022-05-16'
2221
----
2322
1022-05-16 1022-05-16 1022-05-16 00:00:00.000000 1022-05-16 00:00:00.000000 +0000
2423

tests/sqllogictests/suites/query/functions/02_0002_function_cast.test

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,8 @@ SELECT to_timestamp(1640019661000000) = to_timestamp('2021-12-20 17:01:01.000000
204204
statement error 1006
205205
SELECT to_timestamp('2020.10.')
206206

207-
# FIXME: After Parser update then remove ::STRING
208207
query T
209-
select to_timestamp_tz(to_timestamp('2021-12-20 17:01:01.000000'))::STRING
208+
select to_timestamp_tz(to_timestamp('2021-12-20 17:01:01.000000'))
210209
----
211210
2021-12-20 17:01:01.000000 +0000
212211

0 commit comments

Comments
 (0)