fix(binder): different UDAF call must have unique display_name (#17500)

different UDAF call should have unique display_name

Author: forsaken628

src/query/sql/src/planner/format/display_rel_operator.rs

@@ -113,17 +113,7 @@ pub fn format_scalar(scalar: &ScalarExpr) -> String {
         ScalarExpr::UDFLambdaCall(udf) => {
             format!("{}({})", &udf.func_name, format_scalar(&udf.scalar))
         }
-        ScalarExpr::UDAFCall(udaf) => {
-            format!(
-                "{}({})",
-                &udaf.name,
-                udaf.arguments
-                    .iter()
-                    .map(format_scalar)
-                    .collect::<Vec<String>>()
-                    .join(", ")
-            )
-        }
+        ScalarExpr::UDAFCall(udaf) => udaf.display_name.clone(),
         ScalarExpr::AsyncFunctionCall(async_func) => async_func.display_name.clone(),
     }
 }

src/query/sql/src/planner/semantic/type_check.rs

@@ -4107,19 +4107,22 @@ impl<'a> TypeChecker<'a> {
             code: code_blob.into(),
         });
 
-        let mut arguments = Vec::with_capacity(arg_types.len());
-        for (argument, dest_type) in args.iter().zip(arg_types.iter()) {
-            let box (arg, ty) = self.resolve(argument)?;
-            if ty != *dest_type {
-                arguments.push(wrap_cast(&arg, dest_type));
-            } else {
-                arguments.push(arg);
-            }
-        }
+        let arguments = args
+            .iter()
+            .zip(arg_types.iter())
+            .map(|(argument, dest_type)| {
+                let box (arg, ty) = self.resolve(argument)?;
+                Ok(if ty == *dest_type {
+                    arg
+                } else {
+                    wrap_cast(&arg, dest_type)
+                })
+            })
+            .collect::<Result<Vec<_>>>()?;
 
         let display_name = format!(
             "{name}({})",
-            arg_types.iter().map(|arg| format!("{arg}")).join(", ")
+            args.iter().map(|arg| format!("{:#}", arg)).join(", ")
         );
 
         self.bind_context.have_udf_script = true;

tests/sqllogictests/suites/base/03_common/03_0047_select_udaf.test

@@ -1,5 +1,5 @@
 statement ok
-CREATE or replace FUNCTION weighted_avg (INT, INT) STATE {sum INT, weight INT} RETURNS FLOAT
+CREATE or REPLACE FUNCTION weighted_avg (INT, INT) STATE {sum INT, weight INT} RETURNS FLOAT
 LANGUAGE javascript AS $$
 export function create_state() {
     return {sum: 0, weight: 0};
@@ -45,3 +45,13 @@ select number % 3, weighted_avg(number, 1) from numbers(10) group by 1 order by
 0 4.5
 1 4.0
 2 5.0
+
+query IRR
+select number % 3, weighted_avg(number+1, 1), weighted_avg(number+2, 1) from numbers(10) group by 1 order by 1;
+----
+0 5.5 6.5
+1 5.0 6.0
+2 6.0 7.0
+
+statement ok
+drop function weighted_avg