fix(query): group checker subquery

Author: sundy-li

src/query/sql/src/planner/semantic/grouping_check.rs

@@ -20,7 +20,6 @@ use crate::binder::Visibility;
 use crate::plans::walk_expr_mut;
 use crate::plans::BoundColumnRef;
 use crate::plans::ScalarExpr;
-use crate::plans::SubqueryExpr;
 use crate::plans::VisitorMut;
 use crate::BindContext;
 
@@ -176,6 +175,11 @@ impl VisitorMut<'_> for GroupingChecker<'_> {
                     return Ok(());
                 }
             }
+            ScalarExpr::SubqueryExpr(q) => {
+                if let Some(c) = q.child_expr.as_mut() {
+                    self.visit(c.as_mut())?;
+                }
+            }
             _ => {}
         }
 
@@ -200,9 +204,4 @@ impl VisitorMut<'_> for GroupingChecker<'_> {
         ))
         .set_span(column.span))
     }
-
-    fn visit_subquery_expr(&mut self, _: &mut SubqueryExpr) -> Result<()> {
-        // TODO(leiysky): check subquery in the future
-        Ok(())
-    }
 }

tests/sqllogictests/suites/query/aggregate.test

@@ -36,6 +36,9 @@ select a, sum(sum) as sum from (select a, sum(a) as sum from t group by a, b) as
 1	2
 2	4
 
+statement error must appear in the GROUP BY clause or be used in an aggregate function
+SELECT max(a) FROM t GROUP BY a HAVING b NOT IN(SELECT 3 AS c);
+
 statement ok
 drop table t