Skip to content

Commit fb84280

Browse files
b41shsundy-li
andauthored
fix(storage): fix refresh virtual column using async api (#16656)
* fix(storage): fix refresh virtual column using async api * fix typos * fix --------- Co-authored-by: sundyli <[email protected]>
1 parent a6be8e7 commit fb84280

File tree

13 files changed

+368
-108
lines changed

13 files changed

+368
-108
lines changed

Cargo.lock

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/common/metrics/src/metrics/storage.rs

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,15 @@ static AGG_INDEX_WRITE_BYTES: LazyLock<Counter> =
288288
static AGG_INDEX_WRITE_MILLISECONDS: LazyLock<Histogram> =
289289
LazyLock::new(|| register_histogram_in_milliseconds("fuse_aggregate_index_write_milliseconds"));
290290

291+
// Virtual column metrics.
292+
static BLOCK_VIRTUAL_COLUMN_WRITE_NUMS: LazyLock<Counter> =
293+
LazyLock::new(|| register_counter("fuse_block_virtual_column_write_nums"));
294+
static BLOCK_VIRTUAL_COLUMN_WRITE_BYTES: LazyLock<Counter> =
295+
LazyLock::new(|| register_counter("fuse_block_virtual_column_write_bytes"));
296+
static BLOCK_VIRTUAL_COLUMN_WRITE_MILLISECONDS: LazyLock<Histogram> = LazyLock::new(|| {
297+
register_histogram_in_milliseconds("fuse_block_virtual_column_write_milliseconds")
298+
});
299+
291300
/// Common metrics.
292301
pub fn metrics_inc_omit_filter_rowgroups(c: u64) {
293302
OMIT_FILTER_ROWGROUPS.inc_by(c);
@@ -790,3 +799,16 @@ pub fn metrics_inc_agg_index_write_bytes(c: u64) {
790799
pub fn metrics_inc_agg_index_write_milliseconds(c: u64) {
791800
AGG_INDEX_WRITE_MILLISECONDS.observe(c as f64);
792801
}
802+
803+
/// Virtual column metrics.
804+
pub fn metrics_inc_block_virtual_column_write_nums(c: u64) {
805+
BLOCK_VIRTUAL_COLUMN_WRITE_NUMS.inc_by(c);
806+
}
807+
808+
pub fn metrics_inc_block_virtual_column_write_bytes(c: u64) {
809+
BLOCK_VIRTUAL_COLUMN_WRITE_BYTES.inc_by(c);
810+
}
811+
812+
pub fn metrics_inc_block_virtual_column_write_milliseconds(c: u64) {
813+
BLOCK_VIRTUAL_COLUMN_WRITE_MILLISECONDS.observe(c as f64);
814+
}

src/query/ee/Cargo.toml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ databend-common-meta-api = { workspace = true }
3131
databend-common-meta-app = { workspace = true }
3232
databend-common-meta-store = { workspace = true }
3333
databend-common-meta-types = { workspace = true }
34+
databend-common-metrics = { workspace = true }
35+
databend-common-pipeline-core = { workspace = true }
36+
databend-common-pipeline-sinks = { workspace = true }
37+
databend-common-pipeline-sources = { workspace = true }
38+
databend-common-pipeline-transforms = { workspace = true }
3439
databend-common-sql = { workspace = true }
3540
databend-common-storage = { workspace = true }
3641
databend-common-storages-fuse = { workspace = true }

0 commit comments

Comments
 (0)