Skip to content

Conversation

@zhyass
Copy link
Member

@zhyass zhyass commented Aug 27, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR changes the location field in AdditionalStatsMeta from Option<Location> to Location.
To ensure backward compatibility with existing serialized metadata where location may be missing or null, we introduce a default_location function with #[serde(default)].
This guarantees that deserialization of old data will succeed, while new data will always include a valid location field.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Aug 27, 2025
@zhyass zhyass added the ci-benchmark Benchmark: run all test label Aug 27, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-18618-a56f19d-1756291290

note: this image tag is only available for internal use.

@BohuTANG BohuTANG requested a review from dantengsky August 27, 2025 15:59
@zhyass zhyass added ci-cloud Build docker image for cloud test and removed ci-benchmark Benchmark: run all test labels Aug 27, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-18618-d755c66-1756313967

note: this image tag is only available for internal use.

@dantengsky dantengsky merged commit 0de16c6 into databendlabs:main Aug 27, 2025
481 of 492 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants