Skip to content

Conversation

@zhyass
Copy link
Member

@zhyass zhyass commented Aug 27, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This commit ensures that the location field in AdditionalStatsMeta is always set (never None) when creating snapshots. Previously, location could be None, causing compatibility issues during schema evolution. By providing a default placeholder (("", 0)), this change facilitates smoother upgrades and backward compatibility for downstream consumers.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Aug 27, 2025
@zhyass zhyass changed the title fix: Ensure AdditionalStatsMeta.location is always populated in snapshots fix[DO NOT MERGE]: Ensure AdditionalStatsMeta.location is always populated in snapshots Aug 27, 2025
@zhyass zhyass added the ci-cloud Build docker image for cloud test label Aug 27, 2025
@zhyass zhyass changed the title fix[DO NOT MERGE]: Ensure AdditionalStatsMeta.location is always populated in snapshots [DO NOT MERGE] fix: Ensure AdditionalStatsMeta.location is always populated in snapshots Aug 27, 2025
@zhyass zhyass changed the title [DO NOT MERGE] fix: Ensure AdditionalStatsMeta.location is always populated in snapshots fix: Ensure AdditionalStatsMeta.location is always populated in snapshots Aug 27, 2025
@databendlabs databendlabs deleted a comment from github-actions bot Aug 27, 2025
@zhyass zhyass marked this pull request as draft August 27, 2025 19:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

🤖 Smart Auto-retry Analysis (Retry 1)

Workflow: 17286262033

📊 Summary

  • Total Jobs: 6
  • Failed Jobs: 2
  • Retryable: 1
  • Code Issues: 1

AUTO-RETRY INITIATED

1 job(s) retried due to infrastructure issues (runner failures, timeouts, etc.)

View Progress

🔍 Job Details

  • build (aarch64, ARM64): Not retryable (Code/Test)
  • 🔄 build (x86_64, X64): ✅ Retryable (Infrastructure)

🤖 About

Automated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed).

@zhyass zhyass changed the title fix: Ensure AdditionalStatsMeta.location is always populated in snapshots fix: [DO NOT MERGE]Ensure AdditionalStatsMeta.location is always populated in snapshots Aug 28, 2025
@zhyass zhyass added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Aug 28, 2025
@zhyass zhyass added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Aug 28, 2025
@zhyass zhyass added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Aug 28, 2025
@zhyass zhyass closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant