-
Notifications
You must be signed in to change notification settings - Fork 15
Sampler and Pester Test Updating #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 69 commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
27bfb41
remove ready for sampler
SQLDBAWithABeard 22fbb00
adding sampler
SQLDBAWithABeard 6d38fc0
Add commit message guidelines for contributors for github copilot
SQLDBAWithABeard 83304cd
Update README.md to enhance module documentation
SQLDBAWithABeard 6666140
Enhance CONTRIBUTING.md with detailed guidelines
SQLDBAWithABeard 377b251
Update CONTRIBUTING.md to include GitHub Copilot usage
SQLDBAWithABeard fab475c
Add PowerShell functions for managing Fabric workspaces
SQLDBAWithABeard bae001b
Update CONTRIBUTING.md to clarify testing steps
SQLDBAWithABeard d1b4f97
Add Contributor Covenant Code of Conduct
SQLDBAWithABeard d82f543
Add instructions for running specific test tags
SQLDBAWithABeard 8a01711
Update CONTRIBUTING.md to clarify installation steps for Microsoft.Po…
jpomfret bcf147b
Add PowerShell functions for managing Fabric recovery points and conf…
jpomfret 9650ed3
Merge pull request #22 from jpomfret/sampler-contribupdate
SQLDBAWithABeard bc1c0f3
Update Assert version in RequiredModules.psd1
SQLDBAWithABeard 95464ee
Refactor Register-FabricWorkspaceToCapacity function
SQLDBAWithABeard 76bc259
Add thank you note to commit message instructions
SQLDBAWithABeard 090d162
Update Documentation for Spark Custom Pool Parameters for Pester Help…
SQLDBAWithABeard cd9be6b
Update Documentation for WorkspaceId Parameter for Pester Help Tests
SQLDBAWithABeard 5cecf3e
Update Parameter Documentation for WorkspaceId for Pester Help Tests
SQLDBAWithABeard 67d2944
Update Documentation for WorkspaceId Parameter for KQL Database, KQL …
SQLDBAWithABeard 32d2e5c
Update commit message instructions for clarity
SQLDBAWithABeard a684b16
Add GitHub Copilot commit message instructions for Pester Help Tests
SQLDBAWithABeard 53388dc
Enhance Test-FabricApiResponse Documentation for Pester Help Tests
SQLDBAWithABeard c49c4aa
Update WorkspaceId Parameter Documentation for Pester Help Tests
SQLDBAWithABeard 5fbc37a
Refactor Set-FabricApiHeaders Function for Pester Help Tests
SQLDBAWithABeard f36065f
Refactor Revoke-FabricExternalDataShares Function for Pester Help Tests
SQLDBAWithABeard 2299bfe
Add missing function definition for Resume-FabricCapacity for Pester …
SQLDBAWithABeard 256a4a8
Remove unnecessary comments and add KQLDatabaseId parameter for Peste…
SQLDBAWithABeard 79aeedd
Add ItemID parameter to Remove-FabricItem function for Pester Help Tests
SQLDBAWithABeard 82a61d2
Add blank line for improved readability in Remove-FabricKQLDatabase f…
SQLDBAWithABeard ad109e6
Refactor Set-FabricApiHeaders function for Pester Help Tests
SQLDBAWithABeard 2352014
Refactor Remove-FabricEnvironmentStagingLibrary function for Pester H…
SQLDBAWithABeard b58d48a
Added from #17
SQLDBAWithABeard 9331515
Merge Capacity functions from Tiagos code #17
SQLDBAWithABeard 8fd4cdd
Update Private Function file to include a function so that there is n…
SQLDBAWithABeard 2cbba11
Enhance KQL and Lakehouse Functions
SQLDBAWithABeard af5ea78
Add PowerShell functions for managing Fabric tenant settings and work…
SQLDBAWithABeard e982526
Refactor Base64 conversion functions for clarity #16 #20
SQLDBAWithABeard da0e234
Refactor Get-FabricCopyJob function for clarity #16 #20
SQLDBAWithABeard bba9b94
Remove commented-out paths in build.yaml for clarity
SQLDBAWithABeard 2e062f7
Add detailed documentation for PowerShell functions Incomplete Help #16
SQLDBAWithABeard 660f402
Rename function for consistency and clarity
SQLDBAWithABeard 25d1a7a
Remove Get-AllFabricCapacities function for clarity
SQLDBAWithABeard 6405e9c
Add Get-FabricCapacities function for Pester Help Tests
SQLDBAWithABeard aaf6d31
Refactor Help Tests to Filter by Exported Commands for Pester Help Tests
SQLDBAWithABeard 912e73d
Refactor Functions for Consistency and Clarity for Help #16 #17
SQLDBAWithABeard e680eb3
Refactor Functions for Consistency and Clarity for Pester Help Tests …
SQLDBAWithABeard d7295eb
Refactor Functions for Clarity and Consistency for Pester Help Tests …
SQLDBAWithABeard 9a61142
Enhance Documentation for Import-FabricItem Function for Pester Help …
SQLDBAWithABeard 049f749
rename duplicate function
SQLDBAWithABeard ec2e6ec
Enhance PowerShell scripts for Microsoft Fabric Incomplete Help #16 #24
SQLDBAWithABeard ed0fc1a
Refactor Script Analyzer Test for Pester Help Tests
SQLDBAWithABeard fe26b54
Refactor Add-FabricWorkspaceIdentity for Pester Help Tests
SQLDBAWithABeard 4a3b92f
used the dbatools formatter
jpomfret 2442161
extra space in help
jpomfret e7ac546
Fix parameter naming in Get-FabricCopyJob function and update examples
jpomfret a732df2
Merge pull request #27 from dataplat/sampler-formatter
SQLDBAWithABeard f66a2dc
Update CONTRIBUTING.md with proper code formatting
SQLDBAWithABeard 1ebaa8f
Merge pull request #23 from jpomfret/sample-jessUpdates
SQLDBAWithABeard ff43d7b
test pushing conflicted files
jpomfret 55ce588
lets run some tests on PR
jpomfret 0fb7272
sample branches to test with
jpomfret edce5ba
Updated the test command in the workflow to ensure proper execution b…
jpomfret 456ab61
Merge pull request #29 from dataplat/testsonPR
jpomfret f04f593
Remove temporary test branch from workflow for Pester Help Tests
jpomfret 076cda7
fix for #25 add config variables to private function so executed on b…
jpomfret 24a437b
Merge pull request #30 from dataplat/testBranch
SQLDBAWithABeard 61c8532
Fix formatting in Get-FabricDatamart example and add error logging me…
jpomfret 8771a96
Merge branch 'develop' into sampler
jpomfret 089e00a
Added an important box for important content.
Frank-Geisler bcd4afe
Update CONTRIBUTING.md for clarity and structure
Frank-Geisler 5ea8de1
Update CONTRIBUTING.md for clarity and structure
Frank-Geisler 8688b35
Update Code of Conduct for clarity and inclusivity
Frank-Geisler b5d532f
Add standard tests for each function (#35)
jpomfret d88808a
update issue template for new function
jpomfret 178a393
Merge branch 'sampler' of https://github.com/dataplat/FabricTools int…
jpomfret f2f63f6
The requirement for PS7 has been abolished #4
NowinskiK d7462e3
Added unit test & fixed validation for WorkspaceName in Get-FabricWor…
NowinskiK 1b6035a
Apply suggestions from code review
jpomfret 3c30e8e
Merge pull request #38 from dataplat/28-WorkspaceName-validation
jpomfret 2161f3d
Validation correction fixes #28 fixes #41
jpomfret a34d18e
Update CmdletBinding to include ConfirmImpact - closes ConfirmImpact …
SQLDBAWithABeard b6a5777
Merge pull request #37 from dataplat/4-ps51
NowinskiK a0ea5b8
Fix for New-FabricDataPipeline - issue with call to Invoke-FabricAPIR…
jpomfret 4f6a395
Add ShouldProcess support for revoke functions
SQLDBAWithABeard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Needed for publishing of examples, build worker defaults to core.autocrlf=input. | ||
| * text eol=autocrlf | ||
|
|
||
| *.mof text eol=crlf | ||
| *.sh text eol=lf | ||
| *.svg eol=lf | ||
|
|
||
| # Ensure any exe files are treated as binary | ||
| *.exe binary | ||
| *.jpg binary | ||
| *.xl* binary | ||
| *.pfx binary | ||
| *.png binary | ||
| *.dll binary | ||
| *.so binary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| name: General question or documentation update | ||
| about: If you have a general question or documentation update suggestion around the resource module. | ||
| --- | ||
| <!-- | ||
| Your feedback and support is greatly appreciated, thanks for contributing! | ||
| --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| name: Problem with the module | ||
| description: If you have a problem using this module, want to report a bug, or suggest an enhancement to this module. | ||
| labels: [] | ||
| assignees: [] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| TITLE: Please be descriptive not sensationalist. | ||
|
|
||
| Your feedback and support is greatly appreciated, thanks for contributing! | ||
|
|
||
| Please provide information regarding your issue under each section below. | ||
| **Write N/A in sections that do not apply, or if the information is not available.** | ||
| - type: textarea | ||
| id: description | ||
| attributes: | ||
| label: Problem description | ||
| description: Details of the scenario you tried and the problem that is occurring, or the enhancement you are suggesting. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: logs | ||
| attributes: | ||
| label: Verbose logs | ||
| description: | | ||
| Verbose logs showing the problem. **NOTE! Sensitive information should be obfuscated.** _Will be automatically formatted as plain text._ | ||
| placeholder: | | ||
| Paste verbose logs here | ||
| render: text | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: reproducible | ||
| attributes: | ||
| label: How to reproduce | ||
| description: Provide the steps to reproduce the problem. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: expectedBehavior | ||
| attributes: | ||
| label: Expected behavior | ||
| description: Describe what you expected to happen. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: currentBehavior | ||
| attributes: | ||
| label: Current behavior | ||
| description: Describe what actually happens. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: suggestedSolution | ||
| attributes: | ||
| label: Suggested solution | ||
| description: Do you have any suggestions how to solve the issue? | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: targetNodeOS | ||
| attributes: | ||
| label: Operating system the target node is running | ||
| description: | | ||
| Please provide as much as possible about the node running FabricTools. _Will be automatically formatted as plain text._ | ||
|
|
||
| To help with this information: | ||
| - On a Linux distribution, please provide the distribution name, version, and release. The following command can help get this information: `cat /etc/*-release && cat /proc/version` | ||
| - On macOS, please provide the product version and build version. The following command can help get this information: `sw_vers` | ||
| - On a Windows OS please provide edition, version, build, and language. The following command can help get this information: `Get-ComputerInfo -Property @('OsName','OsOperatingSystemSKU','OSArchitecture','WindowsVersion','WindowsBuildLabEx','OsLanguage','OsMuiLanguages')` | ||
| placeholder: | | ||
| Add operating system information here | ||
| render: text | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: targetNodePS | ||
| attributes: | ||
| label: PowerShell version and build the target node is running | ||
| description: | | ||
| Please provide the version and build of PowerShell the target node is running. _Will be automatically formatted as plain text._ | ||
|
|
||
| To help with this information, please run this command: `$PSVersionTable` | ||
| placeholder: | | ||
| Add PowerShell information here | ||
| render: text | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: moduleVersion | ||
| attributes: | ||
| label: Module version used | ||
| description: | | ||
| Please provide the version of the FabricTools module that was used. _Will be automatically formatted as plain text._ | ||
|
|
||
| To help with this information, please run this command: `Get-Module -Name 'FabricTools' -ListAvailable | ft Name,Version,Path` | ||
| placeholder: | | ||
| Add module information here | ||
| render: text | ||
| validations: | ||
| required: true | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| name: Problem with a resource | ||
| description: If you have a problem, bug, or enhancement with a resource in this resource module. | ||
| labels: [] | ||
| assignees: [] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Please prefix the issue title (above) with the resource name, e.g. 'ResourceName: Short description of my issue'! | ||
|
|
||
| Your feedback and support is greatly appreciated, thanks for contributing! | ||
| - type: textarea | ||
| id: description | ||
| attributes: | ||
| label: Problem description | ||
| description: Details of the scenario you tried and the problem that is occurring. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: logs | ||
| attributes: | ||
| label: Verbose logs | ||
| description: | | ||
| Verbose logs showing the problem. **NOTE! Sensitive information should be obfuscated.** _Will be automatically formatted as plain text._ | ||
| placeholder: | | ||
| Paste verbose logs here | ||
| render: text | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: configuration | ||
| attributes: | ||
| label: DSC configuration | ||
| description: | | ||
| The DSC configuration that is used to reproduce the issue (as detailed as possible). **NOTE! Sensitive information should be obfuscated.** _Will be automatically formatted as PowerShell code._ | ||
| placeholder: | | ||
| Paste DSC configuration here | ||
| render: powershell | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: suggestedSolution | ||
| attributes: | ||
| label: Suggested solution | ||
| description: Do you have any suggestions how to solve the issue? | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: targetNodeOS | ||
| attributes: | ||
| label: Operating system the target node is running | ||
| description: | | ||
| Please provide as much as possible about the target node, for example edition, version, build, and language. _Will be automatically formatted as plain text._ | ||
|
|
||
| On OS with WMF 5.1 the following command can help get this information: `Get-ComputerInfo -Property @('OsName','OsOperatingSystemSKU','OSArchitecture','WindowsVersion','WindowsBuildLabEx','OsLanguage','OsMuiLanguages')` | ||
| placeholder: | | ||
| Add operating system information here | ||
| render: text | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: targetNodePS | ||
| attributes: | ||
| label: PowerShell version and build the target node is running | ||
| description: | | ||
| Please provide the version and build of PowerShell the target node is running. _Will be automatically formatted as plain text._ | ||
|
|
||
| To help with this information, please run this command: `$PSVersionTable` | ||
| placeholder: | | ||
| Add PowerShell information here | ||
| render: text | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: moduleVersion | ||
| attributes: | ||
| label: FabricTools version | ||
| description: | | ||
| Please provide the version of the FabricTools module that was used. _Will be automatically formatted as plain text._ | ||
|
|
||
| To help with this information, please run this command: `Get-Module -Name 'FabricTools' -ListAvailable | ft Name,Version,Path` | ||
| placeholder: | | ||
| Add module information here | ||
| render: text | ||
| validations: | ||
| required: true | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: New resource proposal | ||
| description: If you have a new resource proposal that you think should be added to this resource module. | ||
| title: "NewResourceName: New resource proposal" | ||
| labels: [] | ||
| assignees: [] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Please replace `NewResourceName` in the issue title (above) with your proposed resource name. | ||
|
|
||
| Thank you for contributing and making this resource module better! | ||
| - type: textarea | ||
| id: description | ||
| attributes: | ||
| label: Resource proposal | ||
| description: Provide information how this resource will/should work and how it will help users. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: proposedProperties | ||
| attributes: | ||
| label: Proposed properties | ||
| description: | | ||
| List all the proposed properties that the resource should have (key, required, write, and/or read). For each property provide a detailed description, the data type, if a default value should be used, and if the property is limited to a set of values. | ||
| value: | | ||
| Property | Type qualifier | Data type | Description | Default value | Allowed values | ||
| --- | --- | --- | --- | --- | --- | ||
| PropertyName | Key | String | Detailed description | None | None | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: considerations | ||
| attributes: | ||
| label: Special considerations or limitations | ||
| description: | | ||
| Provide any considerations or limitations you can think of that a contributor should take in account when coding the proposed resource, and or what limitations a user will encounter or should consider when using the proposed resource. | ||
| validations: | ||
| required: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| blank_issues_enabled: false | ||
| contact_links: | ||
| - name: "Virtual PowerShell User Group #DSC channel" | ||
| url: https://dsccommunity.org/community/contact/ | ||
| about: "To talk to the community and maintainers of DSC Community, please visit the #DSC channel." | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # Pull Request | ||
|
|
||
| <!-- | ||
| Thanks for submitting a Pull Request (PR) to this project. | ||
| Your contribution to this project is greatly appreciated! | ||
|
|
||
| TITLE: Please be descriptive not sensationalist. | ||
| Prepend the title with the [DscResourceName] if your PR is specific to a DSC resource. | ||
| Also prepend with [BREAKING CHANGE] if relevant. | ||
| i.e. [BREAKING CHANGE][xFile] Add security descriptor property | ||
|
|
||
| You may remove this comment block, and the other comment blocks, but please | ||
| keep the headers and the task list. | ||
| Try to keep your PRs atomic: changes grouped in smallest batch affecting a single logical unit. | ||
| --> | ||
|
|
||
| ## Pull Request (PR) description | ||
|
|
||
| <!-- | ||
| Replace this comment block with a description of your PR to provide context. | ||
| Please be describe the intent and link issue where the problem has been discussed. | ||
| try to link the issue that it fixes by providing the verb and ref: [fix|close #18] | ||
|
|
||
| After the description, please concisely list the changes as per keepachangelog.com | ||
| This **should** duplicate what you've updated in the changelog file. | ||
|
|
||
| ### Added | ||
| - for new features [closes #15] | ||
| ### Changed | ||
| - for changes in existing functionality. | ||
| ### Deprecated | ||
| - for soon-to-be removed features. | ||
| ### Security | ||
| - in case of vulnerabilities. | ||
| ### Fixed | ||
| - for any bug fixes. [fix #52] | ||
| ### Removed | ||
| - for now removed features. | ||
| --> | ||
|
|
||
| ## Task list | ||
|
|
||
| <!-- | ||
| To aid community reviewers in reviewing and merging your PR, please take | ||
| the time to run through the below checklist and make sure your PR has | ||
| everything updated as required. | ||
|
|
||
| Change to [x] for each task in the task list that applies to your PR. | ||
| For those task that don't apply to you PR, leave those as is. | ||
| --> | ||
|
|
||
| - [ ] The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs. | ||
| - [ ] Added an entry under the Unreleased section of in the CHANGELOG.md as per [format](https://keepachangelog.com/en/1.0.0/). | ||
| - [ ] Local clean build passes without issue or fail tests (`build.ps1 -ResolveDependency`). | ||
| - [ ] Resource documentation added/updated in README.md. | ||
| - [ ] Resource parameter descriptions added/updated in README.md, schema.mof | ||
| and comment-based help. | ||
| - [ ] Comment-based help added/updated. | ||
| - [ ] Localization strings added/updated in all localization files as appropriate. | ||
| - [ ] Examples appropriately added/updated. | ||
| - [ ] Unit tests added/updated. See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md). | ||
| - [ ] Integration tests added/updated (where possible). See [DSC Resource Testing Guidelines](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md). | ||
| - [ ] New/changed code adheres to [DSC Resource Style Guidelines](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md) and [Best Practices](https://github.com/PowerShell/DscResources/blob/master/BestPractices.md). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Limit the subject line to 50 characters | ||
| Capitalize the subject/description line | ||
| Do not end the subject line with a period | ||
| Separate the subject from the body with a blank line | ||
| Use the imperative mood in the subject line | ||
| The subject line should be a single sentence with an action word and target with some reasoning add "for Pester Help Tests" | ||
| Use the body to explain what and why in a friendly kind manner | ||
| Say thank you at the end of the message |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.