Skip to content

Conversation

@jpomfret
Copy link
Contributor

  • adds standard unit tests used in dbatools

still need to

  • check output - why does it say 0 expected params for each

  • check functions that already had a test file

  • do something for functions that have no params

@github-actions
Copy link

github-actions bot commented May 16, 2025

Linux Test Results

1 488 tests  +220   1 347 ✅ +412   37s ⏱️ ±0s
  213 suites +198       1 💤 ±  0 
    1 files   ±  0     140 ❌  - 192 

For more details on these failures, see this check.

Results for commit 937ec56. ± Comparison against base commit 089e00a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 16, 2025

WinPS51 Test Results

1 488 tests  +220   1 347 ✅ +412   45s ⏱️ +4s
  213 suites +198       1 💤 ±  0 
    1 files   ±  0     140 ❌  - 192 

For more details on these failures, see this check.

Results for commit 937ec56. ± Comparison against base commit 089e00a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 16, 2025

WinPS71 Test Results

1 488 tests  +220   1 347 ✅ +412   45s ⏱️ +2s
  213 suites +198       1 💤 ±  0 
    1 files   ±  0     140 ❌  - 192 

For more details on these failures, see this check.

Results for commit 937ec56. ± Comparison against base commit 089e00a.

♻️ This comment has been updated with latest results.

This update improves the structure of the parameter validation in the Add-FabricWorkspaceRoleAssignment tests. By moving the expected parameters setup into the BeforeDiscovery and BeforeAll blocks, we enhance readability and maintainability.

Thank you!
…for Pester Help Tests

This change simplifies the parameter validation by removing the default parameters that are not required for the Add-FabricWorkspaceRoleAssignment function. This helps to ensure that the tests focus on the essential parameters, improving clarity and maintainability.

Thank you!
Consolidate expected parameters into a single array for better readability and maintainability. This change simplifies the parameter validation logic in the tests for the Add-FabricWorkspaceRoleAssignment function.

Thank you!
This change adds "Jess'sMissingParam" to the expected parameters for the Add-FabricWorkspaceRoleAssignment tests. This ensures that the tests accurately reflect the parameters used in the command, improving the validation process.

Thank you!
@jpomfret jpomfret closed this May 16, 2025
@SQLDBAWithABeard SQLDBAWithABeard marked this pull request as ready for review May 20, 2025 08:13
@SQLDBAWithABeard SQLDBAWithABeard deleted the testsforall branch May 20, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants