Skip to content

Commit 9e1e48c

Browse files
mfranzkegithub-actions[bot]
mfranzke
and
github-actions[bot]
authored
fix: placeholder for DBSelect with variant floating is moved down (#5616)
* docs: added a necessary example * docs: added an optional example * auto update snapshots (#5617) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs: added a necessary example * fix: placeholder position we cannot rely on a 50% positioning, as the height might change e.g. due to an error message * refactor: corrected name * auto update snapshots (#5618) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update custom-select.json * auto update snapshots (#5619) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * auto update snapshots (#5620) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update README.md * Update README.md * auto update snapshots (#5622) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 94d65c4 commit 9e1e48c

File tree

41 files changed

+484
-1
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+484
-1
lines changed

‎.changeset/chatty-scissors-breathe.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"@db-ux/core-components": patch
3+
"@db-ux/ngx-core-components": patch
4+
"@db-ux/react-core-components": patch
5+
"@db-ux/wc-core-components": patch
6+
"@db-ux/v-core-components": patch
7+
---
8+
9+
fix: placeholder for DBSelect with variant floating is moved down

‎__snapshots__/custom-select/showcase/chromium-highContrast/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png‎

20 KB
Loading

‎__snapshots__/custom-select/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml‎

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1441,4 +1441,48 @@
14411441
- listitem:
14421442
- radio "Option 5"
14431443
- text: Option 5
1444+
- status
1445+
- link "Examples Floating label"
1446+
- text: Floating
1447+
- group:
1448+
- article:
1449+
- radiogroup "id-10300-Floating":
1450+
- list:
1451+
- listitem:
1452+
- radio "Option 1"
1453+
- text: Option 1
1454+
- listitem:
1455+
- radio "Option 2"
1456+
- text: Option 2
1457+
- listitem:
1458+
- radio "Option 3"
1459+
- text: Option 3
1460+
- listitem:
1461+
- radio "Option 4"
1462+
- text: Option 4
1463+
- listitem:
1464+
- radio "Option 5"
1465+
- text: Option 5
1466+
- status
1467+
- text: Floating
1468+
- group:
1469+
- article:
1470+
- radiogroup "id-10301-Floating":
1471+
- list:
1472+
- listitem:
1473+
- radio "Option 1"
1474+
- text: Option 1
1475+
- listitem:
1476+
- radio "Option 2"
1477+
- text: Option 2
1478+
- listitem:
1479+
- radio "Option 3"
1480+
- text: Option 3
1481+
- listitem:
1482+
- radio "Option 4"
1483+
- text: Option 4
1484+
- listitem:
1485+
- radio "Option 5"
1486+
- text: Option 5
1487+
- text: Invalid Message
14441488
- status

‎__snapshots__/custom-select/showcase/chromium/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png‎

23.5 KB
Loading

‎__snapshots__/custom-select/showcase/chromium/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml‎

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1441,4 +1441,48 @@
14411441
- listitem:
14421442
- radio "Option 5"
14431443
- text: Option 5
1444+
- status
1445+
- link "Examples Floating label"
1446+
- text: Floating
1447+
- group:
1448+
- article:
1449+
- radiogroup "id-10300-Floating":
1450+
- list:
1451+
- listitem:
1452+
- radio "Option 1"
1453+
- text: Option 1
1454+
- listitem:
1455+
- radio "Option 2"
1456+
- text: Option 2
1457+
- listitem:
1458+
- radio "Option 3"
1459+
- text: Option 3
1460+
- listitem:
1461+
- radio "Option 4"
1462+
- text: Option 4
1463+
- listitem:
1464+
- radio "Option 5"
1465+
- text: Option 5
1466+
- status
1467+
- text: Floating
1468+
- group:
1469+
- article:
1470+
- radiogroup "id-10301-Floating":
1471+
- list:
1472+
- listitem:
1473+
- radio "Option 1"
1474+
- text: Option 1
1475+
- listitem:
1476+
- radio "Option 2"
1477+
- text: Option 2
1478+
- listitem:
1479+
- radio "Option 3"
1480+
- text: Option 3
1481+
- listitem:
1482+
- radio "Option 4"
1483+
- text: Option 4
1484+
- listitem:
1485+
- radio "Option 5"
1486+
- text: Option 5
1487+
- text: Invalid Message
14441488
- status

‎__snapshots__/custom-select/showcase/firefox/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png‎

38.2 KB
Loading

‎__snapshots__/custom-select/showcase/firefox/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml‎

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1441,4 +1441,48 @@
14411441
- listitem:
14421442
- radio "Option 5"
14431443
- text: Option 5
1444+
- status
1445+
- link "Examples Floating label"
1446+
- text: Floating
1447+
- group:
1448+
- article:
1449+
- radiogroup "id-10300-Floating":
1450+
- list:
1451+
- listitem:
1452+
- radio "Option 1"
1453+
- text: Option 1
1454+
- listitem:
1455+
- radio "Option 2"
1456+
- text: Option 2
1457+
- listitem:
1458+
- radio "Option 3"
1459+
- text: Option 3
1460+
- listitem:
1461+
- radio "Option 4"
1462+
- text: Option 4
1463+
- listitem:
1464+
- radio "Option 5"
1465+
- text: Option 5
1466+
- status
1467+
- text: Floating
1468+
- group:
1469+
- article:
1470+
- radiogroup "id-10301-Floating":
1471+
- list:
1472+
- listitem:
1473+
- radio "Option 1"
1474+
- text: Option 1
1475+
- listitem:
1476+
- radio "Option 2"
1477+
- text: Option 2
1478+
- listitem:
1479+
- radio "Option 3"
1480+
- text: Option 3
1481+
- listitem:
1482+
- radio "Option 4"
1483+
- text: Option 4
1484+
- listitem:
1485+
- radio "Option 5"
1486+
- text: Option 5
1487+
- text: Invalid Message
14441488
- status

‎__snapshots__/custom-select/showcase/mobile-chrome/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png‎

3.21 KB
Loading

‎__snapshots__/custom-select/showcase/mobile-chrome/should-have-same-aria-snapshot/DBCustomSelect-should-have-same-aria-snapshot.yaml‎

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1509,4 +1509,50 @@
15091509
- radio "Option 5"
15101510
- text: Option 5
15111511
- button "Close"
1512+
- status
1513+
- link "Examples Floating label"
1514+
- text: Floating
1515+
- group:
1516+
- article:
1517+
- radiogroup "id-10300-Floating":
1518+
- list:
1519+
- listitem:
1520+
- radio "Option 1"
1521+
- text: Option 1
1522+
- listitem:
1523+
- radio "Option 2"
1524+
- text: Option 2
1525+
- listitem:
1526+
- radio "Option 3"
1527+
- text: Option 3
1528+
- listitem:
1529+
- radio "Option 4"
1530+
- text: Option 4
1531+
- listitem:
1532+
- radio "Option 5"
1533+
- text: Option 5
1534+
- button "Close"
1535+
- status
1536+
- text: Floating
1537+
- group:
1538+
- article:
1539+
- radiogroup "id-10301-Floating":
1540+
- list:
1541+
- listitem:
1542+
- radio "Option 1"
1543+
- text: Option 1
1544+
- listitem:
1545+
- radio "Option 2"
1546+
- text: Option 2
1547+
- listitem:
1548+
- radio "Option 3"
1549+
- text: Option 3
1550+
- listitem:
1551+
- radio "Option 4"
1552+
- text: Option 4
1553+
- listitem:
1554+
- radio "Option 5"
1555+
- text: Option 5
1556+
- button "Close"
1557+
- text: Invalid Message
15121558
- status

‎__snapshots__/custom-select/showcase/mobile-safari/DBCustomSelect-should-match-screenshot-1/DBCustomSelect-should-match-screenshot.png‎

5.33 KB
Loading

0 commit comments

Comments
 (0)