Commit a6de9e7
Morgan Kerle
🩹 Remove table_owner from text only cols
PR #1057 added several new column names to the `text_only_columns` arg
to the `table_from_rows` call in the `_catalog_filter_table` class
method. This method is called as part of the `dbt docs generate` task.
However, some of the new column names included are not included in
the list of columns returned by certain adapter implementations for the
`__get_catalog` and `__get_catalog_relations`.
For example, the relevant BigQuery and Athena macros do not return a
column named `table_owner` (see #1135).
This results in the agate type checker emitting a warning when
attempting typing checking runs.
Any columns added to the `text_only_columns` argument for the call to
`table_from_rows` in the base implementation should presumably be
columns that are returned by all adapters implementations.1 parent 8be7ed7 commit a6de9e7
2 files changed
+20
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1329 | 1329 | | |
1330 | 1330 | | |
1331 | 1331 | | |
1332 | | - | |
1333 | 1332 | | |
1334 | 1333 | | |
1335 | 1334 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
123 | 126 | | |
124 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
125 | 144 | | |
126 | 145 | | |
127 | 146 | | |
| |||
0 commit comments