Skip to content

Conversation

@davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Oct 7, 2025

Related Issues

Proposed Changes:

  • adds a new delete_all_documents() along with its asynchronous counterpart
  • includes both simple deletion and index recreation modes
  • minimal improvements, missing docstrings, methods converted to static and being called statically

How did you test it?

  • unit tests, integration tests, manual verification
  • added new tests:
    • test_delete_all_documents_no_index_recreation(): Verifies simple deletion functionality
    • test_delete_all_documents_index_recreation(): Tests index recreation with configuration preservation
    • test_delete_all_documents_async_no_index_recreation(): Async version of simple deletion test
    • test_delete_all_documents_async_index_recreation(): Async version of index recreation test

Checklist

@github-actions github-actions bot added integration:qdrant type:documentation Improvements or additions to documentation labels Oct 7, 2025
@davidsbatista davidsbatista changed the title Feat/adding delete all docs to qdrant document store feat: adding delete_all_docs to Qdrant document store Oct 8, 2025
@davidsbatista davidsbatista marked this pull request as ready for review October 8, 2025 09:03
@davidsbatista davidsbatista requested a review from a team as a code owner October 8, 2025 09:03
@davidsbatista davidsbatista requested review from Amnah199 and removed request for a team October 8, 2025 09:03
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, rest looks good to me!

…qdrant/document_store.py

Co-authored-by: Amna Mubashar <[email protected]>
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Sorry for the delay in this review.

@davidsbatista davidsbatista merged commit 5641b7c into main Nov 11, 2025
10 checks passed
@davidsbatista davidsbatista deleted the feat/adding-delete-all-docs-to-QdrantDocumentStore branch November 11, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:qdrant type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants