fix #1091: call destroy instead of close

yasserf · yasserf · commit 0175edbac33d · 2020-11-25T11:32:42.000Z
diff --git a/src/services/http/node/node-http.ts b/src/services/http/node/node-http.ts
@@ -136,8 +136,8 @@ export class NodeHTTP extends DeepstreamPlugin implements DeepstreamHTTPService
 
       const interval = setInterval(() => {
         if ((Date.now() - socketWrapper.lastMessageRecievedAt) > webSocketConnectionEndpoint.wsOptions.heartbeatInterval * 2) {
-          console.log('heartbeat issues')
-          socketWrapper.close()
+          this.services.logger.error(EVENT.INFO, 'Heartbeat missing on websocket, terminating connection')
+          socketWrapper.destroy()
         }
       }, webSocketConnectionEndpoint.wsOptions.heartbeatInterval)
 

Original file line number	Diff line number	Diff line change
`@@ -136,8 +136,8 @@ export class NodeHTTP extends DeepstreamPlugin implements DeepstreamHTTPService`
`136`	`136`
`137`	`137`	`const interval = setInterval(() => {`
`138`	`138`	`if ((Date.now() - socketWrapper.lastMessageRecievedAt) > webSocketConnectionEndpoint.wsOptions.heartbeatInterval * 2) {`
`139`		`- console.log('heartbeat issues')`
`140`		`- socketWrapper.close()`
	`139`	`+ this.services.logger.error(EVENT.INFO, 'Heartbeat missing on websocket, terminating connection')`
	`140`	`+ socketWrapper.destroy()`
`141`	`141`	`}`
`142`	`142`	`}, webSocketConnectionEndpoint.wsOptions.heartbeatInterval)`
`143`	`143`