Skip to content

Commit e3810b0

Browse files
authored
Merge pull request #1086 from redlock/master
Fixed crash caused by TypeError due to missing builder.
2 parents a18384d + 95474a6 commit e3810b0

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
- Updating dependencies
66

7+
## [5.1.4] - 2020.10.16
8+
9+
### Fix
10+
11+
- Fixed bug causing the server to crash with older sdks.
12+
713
## [5.1.3] - 2020.08.08
814

915
### Fix

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@deepstream/server",
3-
"version": "5.1.3",
3+
"version": "5.1.4",
44
"description": "a scalable server for realtime webapps",
55
"main": "./dist/src/deepstream.io.js",
66
"bin": {

src/connection-endpoint/websocket/text/text-protocol/message-builder.ts

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -213,14 +213,13 @@ const BUILDERS = {
213213
*/
214214
export const getMessage = (message: Message, isAck: boolean = false): string => {
215215
if (!BUILDERS[message.topic] || !BUILDERS[message.topic][message.action]) {
216-
console.log(message, isAck)
216+
console.trace('missing builder for', message, isAck)
217+
return ''
217218
}
219+
218220
const builder = BUILDERS[message.topic][message.action]
219-
if (!builder) {
220-
console.trace('missing builder for', message)
221-
return ''
222-
} else {
223-
if (
221+
222+
if (
224223
!message.parsedData && !message.data &&
225224
(
226225
(message.topic === TOPIC.RPC.BYTE && (message.action === PA.RESPONSE.BYTE || message.action === PA.REQUEST.BYTE)) ||
@@ -238,8 +237,7 @@ export const getMessage = (message: Message, isAck: boolean = false): string =>
238237
message.data = typed(JSON.parse(message.data.toString()))
239238
}
240239

241-
return builder(message, isAck)
242-
}
240+
return builder(message, isAck)
243241
}
244242

245243
/**

0 commit comments

Comments
 (0)