Merge three dot menues #5776

nicodh · 2025-11-27T11:30:43Z

TBD:

should we show the Encryption info item in chat list at all?
the generic "dangerColor" seems a bit inappropriate (too pale) - do we need 2 different colors for danger & error?
I moved profile to "more options" in 3dot menu since there is the direct link to the chat header which is much more convenient

Current state:
Main difference between both menues: chatlist has "pin", main chat has "search" and "more options"

context menu:            three-dot-menu menu:


                         search in chat
                         mute notifications
                         --------
pin chat                     
mute notifications       archive chat
archive chat             disappearing messages
--------                 --------
profile
clone chat **
--------                 
block contact *          block contact *
leave group **           leave group/channel
                         clear chat
delete chat              delete chat
encryption info          more options:
                                 profile
                                 clear chat
                                 encryption info
                                 chat audit log



*one-to-one only
**groups only

Note: I will rename the file and the class ChatListContextMenu => ChatContextMenu but after being approved for better reviewing

Simon-Laux · 2025-12-01T11:29:06Z

should we show the Encryption info item in chat list at all?

may not even be useful for groups anymore with key contacts? there are no opportunisitc groups anymore, are there?
And for contacts you can already/still access it from the profile view.

r10s · 2025-12-01T17:47:29Z

should we show the Encryption info item in chat list at all?

"encryption info" is mostly useful for one-to-ones, that is even mentioned in advanced faq.

"group encryption info" is more a debug thing, it does not make sense to upgrade that to three-dot-menu, it would better be placed in group profile as well - but as we do not have the three-dot-menu there atm, let's leave that in the chatlist context menu for now (we anyway stay with two menus) or remove it (if we only have one menu)

there is the idea to have a "three dot menu" also in group profiles

the generic "dangerColor" seems a bit inappropriate (too pale) - do we need 2 different colors for danger & error?

let's go for #ff0c16 for "red danger or error text", this is what we're using on android as well. it works nicely on light and dark mode

but i'd call the color dangerTextColor - it must not be used for red background and white text (as eg. in the buttons)

r10s · 2025-12-01T17:53:49Z

for the "more options" - that can also be flattened, there will stay only "clear chat" after #5773

this also looks better as the "red options" are at the end then ("Clear" and "Delete")

WofWca

There are some issues (not all are critical), but overall I think this is probably a good change, removes duplicate logic.

WofWca · 2025-12-05T11:42:28Z

packages/frontend/themes/_themebase.scss

 $themeDarkOrLight: light !default;
 $colorPrimary: #42a5f5 !default;
-$colorDanger: #f96856 !default;
+$colorDanger: #ff0c16 !default;


The contrast in fact is not satisfactory on either of the themes (dark or light), especially with the "hover highlight".

To fix that we should use different colors for dark and light theme, as @nicodh said.
This also goes for $btnDangerBackground BTW.
Maybe this is for another MR though.

WofWca · 2025-12-05T11:47:47Z

packages/e2e-tests/tests/basic-tests.spec.ts

+    .filter({ hasText: userA.name })
+    .first()
+  await expect(chatListItem).toBeVisible()
+  // check for context menu items


Suggested change

// check for context menu items

// check for context menu items

It's somewhat of a separate test, so let's separate it with a new line at least.

WofWca · 2025-12-05T11:47:53Z

packages/e2e-tests/tests/group-tests.spec.ts

    .getByTestId(`account-item-${userB.id}`)
    .locator('.styles_module_accountBadgeIcon')
  await expect(badgeNumber).toHaveText('1')
+  // check for context menu items


Suggested change

// check for context menu items

// check for context menu items

WofWca · 2025-12-05T11:56:06Z

packages/e2e-tests/tests/basic-tests.spec.ts

+  await chatListItem.click({
+    button: 'right',
+  })
+  await expect(page.getByRole('menu').getByRole('menuitem')).toHaveText([


How about adding tests for the "three-dot menu" as well while we're at it?

(BTW note that there is another place which explicitly tests context menu:)

deltachat-desktop/packages/e2e-tests/tests/chat-list-multiselect.spec.ts

Lines 193 to 210 in 17ba3b0

test.describe('context menu', () => {

test('opens', async () => {

await getChat(7).click()

await expectSelectedChats([7])

await getChat(5).click({

modifiers: ['ControlOrMeta'],

})

await expectSelectedChats([7, 5])

await getChat(5).click({

button: 'right',

})

await expect(page.getByRole('menu').getByRole('menuitem')).toHaveText([

'Pin Chat',

'Mute Notifications',

'Archive Chat',

'Delete Chat',

])

WofWca · 2025-12-05T11:57:05Z

packages/frontend/src/components/chat/ChatContextMenu.tsx

+        action: onClearChat,
+        danger: true,
+      },
+      !isMainView && encryptionInfoItem,


TBH this looks really odd after the "danger" buttons:

Maybe move it up? Right along "view profile / group".

WofWca · 2025-12-05T11:57:57Z

packages/frontend/src/components/chat/ChatContextMenu.tsx

+      {
+        label: tx('menu_delete_chat'),
+        action: onDeleteChats,
+        danger: true,
+      },
+      isMainView && {
+        label: tx('clear_chat'),
+        action: onClearChat,
+        danger: true,
+      },


Suggested change

{

label: tx('menu_delete_chat'),

action: onDeleteChats,

danger: true,

},

isMainView && {

label: tx('clear_chat'),

action: onClearChat,

danger: true,

},

isMainView && {

label: tx('clear_chat'),

action: onClearChat,

danger: true,

},

{

label: tx('menu_delete_chat'),

action: onDeleteChats,

danger: true,

},

Let's swap the two. Makes sense, and is in line with Android and Telegram.

WofWca · 2025-12-05T12:04:38Z

packages/frontend/src/components/chat/ChatContextMenu.tsx

+        action: () => onLeaveGroupOrChannel(singleChat),
+        danger: true,
+      },
+      ephemeralMessagesMenuItem,


How about moving this to just below "mute chat"?

WofWca · 2025-12-05T12:08:54Z

packages/e2e-tests/tests/group-tests.spec.ts

+    'Pin Chat',
+    'Mute Notifications',
+    'Archive Chat',
+    'View Profile',


Suggested change

'View Profile',

'Edit Group',

menu_edit_group string is unused in this version of the MR. I think we shouldn't change this to "View Profile".

That was explicitly requested by @r10s

WofWca · 2025-12-05T12:16:48Z

packages/frontend/src/components/chat/ChatContextMenu.tsx

+    !isGroup &&
+      !singleChat.isDeviceTalk && {
+        label: tx('menu_view_profile'),
+        action: onViewProfile,
+      },


This is also shown for channels, and the button just opens the first recipient's profile.

I think it's best to avoid using isGroup with !, and it's best to use chatType directly.

Edit: OK, never mind, this bug is also present on main.

WofWca · 2025-12-05T12:24:38Z

packages/frontend/src/components/screens/MainScreen/MainScreen.tsx

+      const activeChat = {
+        ...chat,
+        kind: 'ChatListItem',
+      } as unknown as T.ChatListItemFetchResult & { kind: 'ChatListItem' }


Is it hard to avoid a type cast here?

nicodh · 2025-12-06T12:06:29Z

I applied some of the suggestions concerning the order of items. And introduced a new (reduced) chat list type which the full chat is converted to.

nicodh temporarily deployed to test November 27, 2025 11:30 — with GitHub Actions Inactive

nicodh requested a review from r10s November 27, 2025 11:37

nicodh added 7 commits December 5, 2025 09:16

refactor: merge context menues

78a797b

refactor: rearrange context menue items

62422ac

test: add check for context menues

cb6ef14

refactor: rename chat list context menue

a531fa9

change: use other colorDanger

1a9def7

fix: remove audit log dialog after rebase

ed0a045

change: add more danger attr to menu items

348fbfa

nicodh force-pushed the merge-three-dot-menues branch from 29caf37 to 348fbfa Compare December 5, 2025 08:52

nicodh had a problem deploying to test December 5, 2025 08:52 — with GitHub Actions Failure

nicodh marked this pull request as ready for review December 5, 2025 09:00

nicodh temporarily deployed to test December 5, 2025 09:21 — with GitHub Actions Inactive

WofWca requested changes Dec 5, 2025

View reviewed changes

fix: convert full chat type

7a0907f

nicodh temporarily deployed to test December 6, 2025 08:37 — with GitHub Actions Inactive

nicodh requested review from WofWca and removed request for r10s December 6, 2025 12:06

	// check for context menu items

	// check for context menu items

	test.describe('context menu', () => {
	test('opens', async () => {
	await getChat(7).click()
	await expectSelectedChats([7])
	await getChat(5).click({
	modifiers: ['ControlOrMeta'],
	})
	await expectSelectedChats([7, 5])

	await getChat(5).click({
	button: 'right',
	})
	await expect(page.getByRole('menu').getByRole('menuitem')).toHaveText([
	'Pin Chat',
	'Mute Notifications',
	'Archive Chat',
	'Delete Chat',
	])

Uh oh!

Merge three dot menues #5776

Are you sure you want to change the base?

Merge three dot menues #5776

Uh oh!

Conversation

nicodh commented Nov 27, 2025

Uh oh!

Simon-Laux commented Dec 1, 2025

Uh oh!

r10s commented Dec 1, 2025

Uh oh!

r10s commented Dec 1, 2025

Uh oh!

WofWca left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WofWca Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WofWca Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicodh commented Dec 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WofWca Dec 5, 2025 •

edited

Loading

WofWca Dec 5, 2025 •

edited

Loading