Separate null checks from functional assertions

Co-authored-by: eNeRGy164 <[email protected]>

Author: Copilot

tests/DendroDocs.Tool.Tests/AnalyzerSetup/AnalyzerSetupTests.cs

@@ -78,7 +78,8 @@ public void SolutionShouldFilterExcludedProjects()
 
         // Assert
         analyzerSetup.Projects.ShouldHaveSingleItem();
-        analyzerSetup.Projects.ShouldAllBe(p => p.FilePath != null && p.FilePath.EndsWith("Project.csproj"));
+        analyzerSetup.Projects.ShouldAllBe(p => p.FilePath != null);
+        analyzerSetup.Projects.ShouldAllBe(p => p.FilePath!.EndsWith("Project.csproj"));
     }
 
     [TestMethod]
@@ -92,7 +93,8 @@ public void SolutionShouldLoadProject()
 
         // Assert
         analyzerSetup.Projects.ShouldHaveSingleItem();
-        analyzerSetup.Projects.ShouldAllBe(p => p.FilePath != null && p.FilePath.EndsWith("Project.csproj"));
+        analyzerSetup.Projects.ShouldAllBe(p => p.FilePath != null);
+        analyzerSetup.Projects.ShouldAllBe(p => p.FilePath!.EndsWith("Project.csproj"));
     }
 
     [TestMethod]
@@ -108,9 +110,10 @@ public void FolderShouldLoadAllProjects()
         analyzerSetup.Projects.Count().ShouldBe(3);
 
         var projectPaths = analyzerSetup.Projects.Select(p => p.FilePath).ToList();
-        projectPaths.ShouldContain(path => path != null && path.EndsWith("Project.csproj"));
-        projectPaths.ShouldContain(path => path != null && path.EndsWith("OtherProject.csproj"));
-        projectPaths.ShouldContain(path => path != null && path.EndsWith("AnotherProject.csproj"));
+        projectPaths.ShouldAllBe(path => path != null);
+        projectPaths.ShouldContain(path => path!.EndsWith("Project.csproj"));
+        projectPaths.ShouldContain(path => path!.EndsWith("OtherProject.csproj"));
+        projectPaths.ShouldContain(path => path!.EndsWith("AnotherProject.csproj"));
     }
 
     [TestMethod]
@@ -128,7 +131,8 @@ public void FolderShouldFilterTestProjects()
         analyzerSetup.Projects.Count().ShouldBe(3);
 
         var projects = analyzerSetup.Projects.ToList();
-        projects.ShouldAllBe(p => p.FilePath != null && !p.FilePath.Contains("TestProject"));
+        projects.ShouldAllBe(p => p.FilePath != null);
+        projects.ShouldAllBe(p => !p.FilePath!.Contains("TestProject"));
     }
 
     [TestMethod]
@@ -144,7 +148,8 @@ public void FolderShouldFilterExcludedProjects()
 
         // Assert
         analyzerSetup.Projects.ShouldHaveSingleItem();
-        analyzerSetup.Projects.ShouldAllBe(p => p.FilePath != null && p.FilePath.EndsWith("Project.csproj"));
+        analyzerSetup.Projects.ShouldAllBe(p => p.FilePath != null);
+        analyzerSetup.Projects.ShouldAllBe(p => p.FilePath!.EndsWith("Project.csproj"));
     }
 
     [TestMethod]
@@ -168,9 +173,10 @@ public void GlobPatternShouldFindMatchingProjects()
             analyzerSetup.Projects.Count().ShouldBe(3);
 
             var projectPaths = analyzerSetup.Projects.Select(p => p.FilePath).ToList();
-            projectPaths.ShouldContain(path => path != null && path.EndsWith("Project.csproj"));
-            projectPaths.ShouldContain(path => path != null && path.EndsWith("OtherProject.csproj"));
-            projectPaths.ShouldContain(path => path != null && path.EndsWith("AnotherProject.csproj"));
+            projectPaths.ShouldAllBe(path => path != null);
+            projectPaths.ShouldContain(path => path!.EndsWith("Project.csproj"));
+            projectPaths.ShouldContain(path => path!.EndsWith("OtherProject.csproj"));
+            projectPaths.ShouldContain(path => path!.EndsWith("AnotherProject.csproj"));
         }
         finally
         {