feat: add wrong cases

Author: wan2land

reform.test.ts

@@ -46,6 +46,17 @@ Deno.test("reform, n-depth array", () => {
   assertEquals(reform(form), { multiple: [["1"], ["2"], ["3"], ["4"]] });
 });
 
+Deno.test("reform, sparse array", () => {
+  const form = new FormData();
+
+  form.append("multiple[5]", "5");
+  form.append("multiple[3]", "3");
+
+  assertEquals(reform(form), {
+    multiple: [null, null, null, "3", null, "5"], // fill sparse as null
+  });
+});
+
 Deno.test("reform, n-depth, indexed array", () => {
   const form = new FormData();
 
@@ -69,3 +80,74 @@ Deno.test("reform, object array", () => {
     users: [{ id: "10", name: "wan2land" }, { id: "11", name: "wan3land" }],
   });
 });
+
+Deno.test("reform, n-depth object", () => {
+  const form = new FormData();
+
+  form.append("user[id]", "11");
+  form.append("user.name", "wan2land");
+  form.append("user[pet].name", "bori");
+  form.append("user[pet][age]", "5");
+
+  assertEquals(reform(form), {
+    user: {
+      id: "11",
+      name: "wan2land",
+      pet: { name: "bori", age: "5" },
+    },
+  });
+});
+
+Deno.test("reform, wrong array, overwrite", () => {
+  {
+    const form = new FormData();
+
+    form.append("user.name.something", "foo");
+    form.append("user[]", "wan2land");
+    form.append("user.name", "wan2land"); // overwrite!
+
+    assertEquals(reform(form), {
+      user: {
+        name: "wan2land",
+      },
+    });
+  }
+  {
+    const form = new FormData();
+
+    form.append("user[]", "wan3land");
+    form.append("user.name", "wan2land");
+    form.append("user[]", "wan2land"); // overwrite!
+
+    assertEquals(reform(form), {
+      user: ["wan2land"],
+    });
+  }
+});
+
+Deno.test("reform, wrong object, overwrite", () => {
+  {
+    const form = new FormData();
+
+    form.append("user.name", "wan2land");
+    form.append("user", "wan2land");
+    form.append("user.name", "wan2land"); // overwrite!
+
+    assertEquals(reform(form), {
+      user: {
+        name: "wan2land",
+      },
+    });
+  }
+  {
+    const form = new FormData();
+
+    form.append("user", "wan2land");
+    form.append("user.name", "wan2land");
+    form.append("user", "wan2land"); // overwrite!
+
+    assertEquals(reform(form), {
+      user: "wan2land",
+    });
+  }
+});

reform.ts

@@ -1,10 +1,18 @@
 import { parseName } from "./parse_name.ts";
 
+function isPlainObject(value: unknown): value is ReformData {
+  return typeof value === "object" && value !== null && !Array.isArray(value);
+}
+
 export interface ReformData {
   [name: string]: ReformDataValue;
 }
 
-export type ReformDataValue = File | string | ReformData | ReformDataValue[];
+export type ReformDataValue =
+  | File
+  | string
+  | ReformData
+  | (ReformDataValue | null)[];
 
 export function reform<T extends ReformData = ReformData>(form: FormData): T {
   const reformed: ReformData = {};
@@ -14,22 +22,28 @@ export function reform<T extends ReformData = ReformData>(form: FormData): T {
     let data: any = reformed;
     for (const [keyIndex, key] of keys.entries()) {
       if (keyIndex + 1 === keys.length) {
-        if (typeof key === "string" || typeof key === "number") {
+        if (typeof key === "string") {
           data[key] = value;
-        } else if (Array.isArray(data)) {
-          data.push(value);
+        } else if (typeof key === "number") {
+          data[key] = value;
+          // fill sparse
+          for (let i = 0; i < key; i++) {
+            if (!(i in data)) {
+              data[i] = null;
+            }
+          }
         } else {
-          throw new Error("111");
+          data.push(value);
         }
         break;
       }
       const nextKey = keys[keyIndex + 1];
       if (typeof key === "string" || typeof key === "number") {
         if (typeof nextKey === "string") {
-          data[key] = data[key] ?? {};
+          data[key] = isPlainObject(data[key]) ? data[key] : {};
           data = data[key];
         } else {
-          data[key] = data[key] ?? [];
+          data[key] = Array.isArray(data[key]) ? data[key] : [];
           data = data[key];
         }
       } else if (Array.isArray(data)) {
@@ -42,8 +56,6 @@ export function reform<T extends ReformData = ReformData>(form: FormData): T {
           data.push(next);
           data = next;
         }
-      } else {
-        throw new Error("22");
       }
     }
   }