Merge pull request #285 from desktop/upgrade-all-the-things

Upgrade a few dependencies

Author: sergiou87

.github/workflows/ci.yml

@@ -11,13 +11,13 @@ on:
 jobs:
   build:
     name: Build
-    runs-on: windows-2019
+    runs-on: windows-2022
     strategy:
       fail-fast: false
       matrix:
-        os: [windows-2019]
+        os: [windows-2022]
         include:
-          - os: windows-2019
+          - os: windows-2022
             friendlyName: Windows
     timeout-minutes: 10
     steps:
@@ -27,16 +27,7 @@ jobs:
       - name: Install Node.js
         uses: actions/[email protected]
         with:
-          node-version: 18
-
-      # This step can be removed as soon as official Windows arm64 builds are published:
-      # https://github.com/nodejs/build/issues/2450#issuecomment-705853342
-      - run: |
-          $NodeVersion = (node --version) -replace '^.'
-          $NodeFallbackVersion = "15.8.0"
-          & .\script\download-node-lib-win-arm64.ps1 $NodeVersion $NodeFallbackVersion
-        name: Install Windows arm64 node.lib
-
+          node-version: 22.14.0
       - name: Install and build dependencies
         run: yarn
       - name: Lint

package.json

@@ -34,19 +34,19 @@
   "devDependencies": {
     "@types/benchmark": "^1.0.31",
     "@types/jest": "^26.0.13",
-    "@types/node": "^12.0.0",
+    "@types/node": "^22.10.9",
     "benchmark": "^2.1.4",
     "jest": "^26.4.2",
-    "node-abi": "^2.21.0",
+    "node-abi": "^4.9.0",
     "node-gyp": "^11.2.0",
-    "prebuild": "^10.0.1",
+    "prebuild": "^13.0.1",
     "prettier": "^2.0.5",
     "ts-node": "^9.0.0",
-    "typescript": "^3.9.0"
+    "typescript": "^5.8.2"
   },
   "dependencies": {
-    "node-addon-api": "^3.2.1",
-    "prebuild-install": "^5.3.5"
+    "node-addon-api": "^8.3.1",
+    "prebuild-install": "^7.1.3"
   },
   "binary": {
     "napi_versions": [

script/download-node-lib-win-arm64.ps1

@@ -1,14 +1,49 @@
 // to ensure that env not in the CI server log
 
 const path = require('path')
+const fs = require('fs')
 const { spawnSync } = require('child_process')
 
-spawnSync(
-  path.join(
+// Make sure output of the script is logged to the console and also the error is
+// caught and logged.
+if (!process.env.GITHUB_AUTH_TOKEN) {
+  console.error(
+    'GITHUB_AUTH_TOKEN is not set. Please set it to upload prebuilds.'
+  )
+  process.exit(1)
+}
+
+try {
+  const prebuildPath = path.join(
     __dirname,
     '../node_modules/.bin/prebuild' +
       (process.platform === 'win32' ? '.cmd' : '')
-  ),
-  ['--upload-all', process.env.GITHUB_AUTH_TOKEN],
-  { stdio: 'inherit', shell: true }
-)
+  )
+
+  // Check if prebuild command exists
+  if (!fs.existsSync(prebuildPath)) {
+    console.error('Prebuild command not found at:', prebuildPath)
+    process.exit(1)
+  }
+
+  console.log('Uploading prebuilds using:', prebuildPath)
+
+  const result = spawnSync(
+    prebuildPath,
+    ['--upload-all', process.env.GITHUB_AUTH_TOKEN],
+    { stdio: 'inherit', shell: true }
+  )
+
+  if (result.error) {
+    console.error('Error uploading prebuilds:', result.error)
+    process.exit(1)
+  }
+  if (result.status !== 0) {
+    console.error('Prebuild upload failed with status:', result.status)
+    process.exit(result.status)
+  }
+  console.log('Prebuilds uploaded successfully.')
+} catch (error) {
+  console.error('An unexpected error occurred:', error)
+  process.exit(1)
+}