Skip to content

Save new users a lot of pain from rug pullers #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Save new users a lot of pain from rug pullers #142

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbf03be
Save new users a lot of pain from rug pullers
addanus Jun 13, 2021
62778fd
Update update-profile.component.ts
addanus Jun 13, 2021
d38efab
Update update-profile.component.ts
addanus Jun 13, 2021
72e27b1
fixing here just in case
addanus Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/app/update-profile-page/update-profile/update-profile.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ export class UpdateProfileComponent implements OnInit, OnChanges {

founderRewardTooltip() {
return (
"When someone purchases your coin, a percentage of each coin purchase " +
"gets allocated to you as a founder reward.\n\n" +
"A value of 0% means that no new coins get allocated to you when someone buys, " +
"whereas a value of 100% means that nobody other than you can ever get coins because 100% of " +
"every purchase will just go to you.\n\n" +
"Setting this value too high will deter buyers from ever " +
"purchasing your coin. It's a balance, so be careful or just stick " +
"with the default."
"When someone purchases your coin, a percentage " +
"is allocated to you as a 'founder reward'.\n\n" +
"A value of 0% means no value gets rewarded to you for each coin purchased, " +
"whereas a value of 100% means no one other than you gets the value because 100% " +
"goes to you.\n\nSetting it too high will deter others from " +
"buying your coin. Setting it too low risks 'rug-pullers' profitting off of " +
Copy link
Contributor

@AeonSw4n AeonSw4n Jun 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo the sentence with "rug-pullers" should be rephrased (first-time people have no idea of this dynamic).

"your hard work. It's a balance, so be careful. After you've bought what you'd " +
"like of your own coin, consider setting this value to 10-20%."
);
}

Expand Down Expand Up @@ -170,7 +170,7 @@ export class UpdateProfileComponent implements OnInit, OnChanges {
this.profileUpdates.usernameUpdate /*NewUsername*/,
this.profileUpdates.descriptionUpdate /*NewDescription*/,
this.profileUpdates.profilePicUpdate /*NewProfilePic*/,
this.founderRewardInput * 100 /*NewCreatorBasisPoints*/,
this.founderRewardInput * 1000 /*NewCreatorBasisPoints*/,
Copy link
Member

@lazynina lazynina Jun 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in basis points, so multiplying by 1000 will result in an error. You can't have a founder's reward > 100%.

Copy link
Author

@addanus addanus Jun 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! I knew I should have reviewed that more closely. It was a last minute quick addition. Sry!!! The text should be updated at least.

1.25 * 100 * 100 /*NewStakeMultipleBasisPoints*/,
false /*IsHidden*/,
// End params
Expand Down