Skip to content

Commit 81cf311

Browse files
authored
Merge branch 'main' into fix/custom-chart-deploy
2 parents 4d594aa + 5e73500 commit 81cf311

File tree

9 files changed

+26
-12
lines changed

9 files changed

+26
-12
lines changed

scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/templates/deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ spec:
209209
{{- end}}
210210
{{- end}}
211211
containers:
212-
- name: {{ $.Chart.Name }}
212+
- name: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
213213
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
214214
imagePullPolicy: {{ $.Values.image.pullPolicy }}
215215
{{- if $.Values.containerSpec.lifecycle.enabled }}
@@ -825,7 +825,7 @@ spec:
825825
{{- end}}
826826
{{- end}}
827827
containers:
828-
- name: {{ $.Chart.Name }}
828+
- name: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
829829
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
830830
imagePullPolicy: {{ $.Values.image.pullPolicy }}
831831
{{- if $.Values.containerSpec.lifecycle.enabled }}

scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/templates/hpa.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ spec:
4343
- type: ContainerResource
4444
containerResource:
4545
name: cpu
46-
container: {{ $.Chart.Name }}
46+
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
4747
target:
4848
type: Utilization
4949
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
@@ -52,7 +52,7 @@ spec:
5252
- type: ContainerResource
5353
containerResource:
5454
name: memory
55-
container: {{ $.Chart.Name }}
55+
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
5656
target:
5757
type: Utilization
5858
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}
@@ -126,7 +126,7 @@ spec:
126126
- type: ContainerResource
127127
containerResource:
128128
name: cpu
129-
container: {{ $.Chart.Name }}
129+
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
130130
target:
131131
type: Utilization
132132
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
@@ -135,7 +135,7 @@ spec:
135135
- type: ContainerResource
136136
containerResource:
137137
name: memory
138-
container: {{ $.Chart.Name }}
138+
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
139139
target:
140140
type: Utilization
141141
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}

scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/values.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ pauseForSecondsBeforeSwitchActive: 30
3838
waitForSecondsBeforeScalingDown: 30
3939
autoPromotionSeconds: 30
4040

41+
# Optional override for the main container name. If provided, this name will be used
42+
# for the primary container instead of the default chart-derived name.
43+
containerName: ""
44+
4145
Spec:
4246
Affinity:
4347
Key: ""
@@ -704,6 +708,8 @@ customPodLabels: {}
704708

705709
secondaryWorkload:
706710
enabled: false
711+
# Optional override for secondary workload's main container name
712+
containerName: ""
707713
Spec:
708714
Affinity:
709715
Key: ""

scripts/devtron-reference-helm-charts/reference-chart_5-1-0/templates/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ spec:
227227
{{- end}}
228228
{{- end}}
229229
containers:
230-
- name: {{ $.Chart.Name }}
230+
- name: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
231231
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
232232
imagePullPolicy: {{ $.Values.image.pullPolicy }}
233233
{{- if $.Values.containerSpec.lifecycle.enabled }}

scripts/devtron-reference-helm-charts/reference-chart_5-1-0/templates/hpa.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ spec:
4343
- type: ContainerResource
4444
containerResource:
4545
name: cpu
46-
container: {{ $.Chart.Name }}
46+
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
4747
target:
4848
type: Utilization
4949
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
@@ -52,7 +52,7 @@ spec:
5252
- type: ContainerResource
5353
containerResource:
5454
name: memory
55-
container: {{ $.Chart.Name }}
55+
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
5656
target:
5757
type: Utilization
5858
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}

scripts/devtron-reference-helm-charts/reference-chart_5-1-0/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ pauseForSecondsBeforeSwitchActive: 30
3737
waitForSecondsBeforeScalingDown: 30
3838
autoPromotionSeconds: 30
3939

40+
# Optional override for the main container name. If provided, this name will be used
41+
# for the primary container instead of the default chart-derived name.
42+
containerName: ""
43+
4044
Spec:
4145
Affinity:
4246
Key:

scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/templates/hpa.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ spec:
4444
- type: ContainerResource
4545
containerResource:
4646
name: cpu
47-
container: {{ $.Chart.Name }}
47+
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
4848
target:
4949
type: Utilization
5050
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
@@ -53,7 +53,7 @@ spec:
5353
- type: ContainerResource
5454
containerResource:
5555
name: memory
56-
container: {{ $.Chart.Name }}
56+
container: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
5757
target:
5858
type: Utilization
5959
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}

scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/templates/statefulset.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ spec:
220220
{{- end}}
221221
{{- end}}
222222
containers:
223-
- name: {{ $.Chart.Name }}
223+
- name: "{{ if $.Values.containerName }}{{ $.Values.containerName }}{{ else }}{{ $.Chart.Name }}{{ end }}"
224224
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
225225
imagePullPolicy: {{ $.Values.image.pullPolicy }}
226226
{{- if $.Values.containerSpec.lifecycle.enabled }}

scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ pauseForSecondsBeforeSwitchActive: 30
3636
waitForSecondsBeforeScalingDown: 30
3737
autoPromotionSeconds: 30
3838

39+
# Optional override for the main container name. If provided, this name will be used
40+
# for the primary container instead of the default chart-derived name.
41+
containerName: ""
42+
3943
Spec:
4044
Affinity:
4145
Key:

0 commit comments

Comments
 (0)